Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate generator package to root #2245

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: migrate generator package to root #2245

merged 1 commit into from
Oct 31, 2023

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Oct 31, 2023 •
edited
Loading

Description

In advance of the build rework migration, isolating the generator moving out of the tools folder (which is going away in the new build).

How and where has this been tested?

  • yarn new

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

🚀 Deployed on https://pr-2245--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 17:19 Inactive
@castastrophe castastrophe force-pushed the chore-migrate-generator-package branch from 7be949c to eb6111d Compare October 31, 2023 17:33
@castastrophe castastrophe marked this pull request as ready for review October 31, 2023 17:33
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 17:38 Inactive
@castastrophe castastrophe force-pushed the chore-migrate-generator-package branch from eb6111d to 0ddb93e Compare October 31, 2023 17:39
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 17:45 Inactive
pfulton
pfulton approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Ship it.

@castastrophe castastrophe merged commit 57d5c3e into main Oct 31, 2023
4 checks passed
@castastrophe castastrophe deleted the chore-migrate-generator-package branch October 31, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfulton pfulton pfulton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@castastrophe @pfulton