feat(ui-icons): migrate icon compiler to distinct package #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File metricsSummaryTotal size: 4.03 MB*
Detailsui-icons
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
from
38fda1c to
995bb3b
Compare
|
🚀 Deployed on https://pr-2343--spectrum-css.netlify.app |
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
from
995bb3b to
568883c
Compare
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
2 times, most recently
from
c9944f0 to
776c5d5
Compare
castastrophe
added
size-3 M
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
4 times, most recently
from
358d92c to
b18bbce
Compare
pfulton
approved these changes
Dec 6, 2023
mdt2
approved these changes
Dec 6, 2023
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
7 times, most recently
from
533c41d to
24b0db2
Compare
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
2 times, most recently
from
f1d6019 to
5df7824
Compare
pfulton
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Just one thing here about the version number, @castastrophe
| @@ -0,0 +1,28 @@ | |||
| { | |||
| "name": "@spectrum-css/ui-icons", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
Should we just make this 1.0.0?
There was a problem hiding this comment.
I did this because during the release it will bump it and I thought this would make it easier to target the 1.0 release we want. I'll change it during the release process if it doesn't bump correctly.
BREAKING CHANGE: - icon will no longer contain SVG assets
castastrophe
force-pushed
the
feat-ui-icons-migration
branch
from
5df7824 to
c07e9e2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move SVG processing out of the CSS component package @spectrum-css/icon into a distinct package @spectrum-css/ui-icons.
Why?
Keeps tooling for SVG parsing separate from the tasks performed on CSS-only assets and allows consumers to pull in a focused package with the SVG assets they need for product.
How and where has this been tested?
Opened a PR against SWC with the necessary updates & tested this change using a yarn link to the new package.
Validation steps
To-do list