Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cyclebutton): deprecate component #2538

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mdt2
Copy link
Collaborator

@mdt2 mdt2 commented Feb 16, 2024

Description

Deprecate cyclebutton. Setup was completed and tested in #2536

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Check that the steps to remove a deprecated component from the monorepo have been completed:

  • cyclebutton has been removed from the repo
  • In docs site, cyclebutton shows deprecated message
  • In storybook, cyclebutton is in the deprecated section with deprecated status
  • I have asked a package maintainer to officially deprecate the package in npm Cassondra already did this ✨ @mdt2

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@mdt2 mdt2 requested a review from castastrophe February 16, 2024 18:35
Copy link
Contributor

github-actions bot commented Feb 16, 2024

File metrics

Summary

Total size: 3.93 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Feb 16, 2024

🚀 Deployed on https://pr-2538--spectrum-css.netlify.app

@castastrophe castastrophe added ready-to-merge deprecation Flag PRs or issues with this to indicate a component is being deprecated. labels Feb 16, 2024
@castastrophe castastrophe force-pushed the mdt2/css-514-deprecate-cyclebutton branch from a07d7a4 to eaa0f72 Compare February 16, 2024 19:00
@castastrophe castastrophe enabled auto-merge (squash) February 16, 2024 19:01
@castastrophe castastrophe merged commit 8e2010c into main Feb 16, 2024
11 of 12 checks passed
@castastrophe castastrophe deleted the mdt2/css-514-deprecate-cyclebutton branch February 16, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Flag PRs or issues with this to indicate a component is being deprecated. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants