Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define missing color property in some components #2754

Merged
merged 2 commits into from
May 14, 2024
Merged

feat: define missing color property in some components #2754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
497635a
docs(meter): use typography in storybook for heading
jawinn May 10, 2024
7f9def6
feat: define color property in some components
jawinn May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/new-sheep-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@spectrum-css/datepicker": minor
"@spectrum-css/splitview": minor
"@spectrum-css/treeview": minor
"@spectrum-css/slider": minor
"@spectrum-css/radio": minor
"@spectrum-css/well": minor
"@spectrum-css/progressbar": patch
---

Sets the `color` property in parts of some components that were relying on inheriting a color from higher up in the DOM.
521 changes: 263 additions & 258 deletions components/datepicker/index.css
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions components/datepicker/metadata/mods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
| `--mod-datepicker-border-color-disabled` |
| `--mod-datepicker-border-radius` |
| `--mod-datepicker-border-radius-quiet` |
| `--mod-datepicker-dash-color` |
| `--mod-datepicker-dash-color-disabled` |
| `--mod-datepicker-dash-font-size` |
| `--mod-datepicker-dash-line-height` |
Expand Down
11 changes: 6 additions & 5 deletions components/progressbar/stories/meter.template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@ import { classMap } from "lit/directives/class-map.js";
import { styleMap } from "lit/directives/style-map.js";

import { Template as FieldLabel } from "@spectrum-css/fieldlabel/stories/template.js";
import { Template as Typography } from "@spectrum-css/typography/stories/template.js";

import "../index.css";

export const Template = ({
rootClass = "spectrum-ProgressBar",
customClasses = [],
customStyles = {},
headingStyles = {
"text-decoration": "underline",
},
items = [],
label = "Storage space",
value,
Expand All @@ -25,9 +23,12 @@ export const Template = ({
const meterLabel = meter.label ?? label;
const fill = meter.meterFill ?? meterFill;

// @todo: Should the heading content render through typography?
return html`
<p style=${styleMap(headingStyles)}>${heading}</p>
${Typography({
semantics: "heading",
size: "xs",
content: [heading],
})}
<div
class=${classMap({
[rootClass]: true,
Expand Down
794 changes: 366 additions & 428 deletions components/radio/index.css
View file
Open in desktop

Large diffs are not rendered by default.

1,176 changes: 576 additions & 600 deletions components/slider/index.css
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions components/slider/metadata/mods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
| `--mod-slider-ramp-track-height` |
| `--mod-slider-range-track-reset` |
| `--mod-slider-tick-handle-background-color` |
| `--mod-slider-tick-label-color` |
| `--mod-slider-tick-mark-border-radius` |
| `--mod-slider-tick-mark-color` |
| `--mod-slider-tick-mark-color-disabled` |
Expand Down
Loading
Loading