Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar): remove outline and reduce redundancy #3105

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Sep 12, 2024

Description

  • Updates the avatar link styles to reduce redundancy and properly remove the border that was displayed in high contrast mode.

How and where has this been tested?

  • Verified in assistiv labs Windows High Contrast Mode

Validation steps

  1. Run Storybook locally (or reference the link for this PR).
  2. Navigate to Assistiv Labs and start a Windows High Contrast Mode VM (if running the branch locally, you'll need to enable the Assistiv Labs tunnel to access Storybook).
  3. Enable Windows High Contrast Mode.
  4. Navigate to the Avatar component in Storybook.
  5. Verify that the square yellow outline no longer renders around the avatar component.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Screenshot 2024-09-12 at 1 11 52 PM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added run_vrt For use on PRs looking to kick off VRT ready-to-merge labels Sep 12, 2024
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 2eb6acd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/avatar Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 12, 2024

🚀 Deployed on https://pr-3105--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Sep 12, 2024

File metrics

Summary

Total size: 4.10 MB*
Total change (Δ): ⬇ 0.17 KB (-0.00%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
avatar 4.99 KB ⬇ 0.06 KB

Details

avatar

File Head Base Δ
index-base.css 4.99 KB 5.04 KB ⬇ 0.06 KB (-1.07%)
index-vars.css 4.99 KB 5.04 KB ⬇ 0.06 KB (-1.07%)
index.css 4.99 KB 5.04 KB ⬇ 0.06 KB (-1.07%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf closed this Sep 12, 2024
@cdransf cdransf reopened this Sep 12, 2024
@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch from 3af4a2f to 8ea6fc7 Compare September 13, 2024 14:39
@cdransf cdransf closed this Sep 13, 2024
@cdransf cdransf reopened this Sep 13, 2024
@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch 2 times, most recently from dd37285 to a41bc89 Compare September 13, 2024 16:35
@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch from a41bc89 to 04dda37 Compare September 13, 2024 17:49
@cdransf cdransf closed this Sep 13, 2024
@cdransf cdransf reopened this Sep 13, 2024
@cdransf cdransf closed this Sep 13, 2024
@cdransf cdransf reopened this Sep 13, 2024
@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch from 04dda37 to 8ecacc5 Compare September 16, 2024 16:10
@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch 2 times, most recently from 6c67835 to af7ce27 Compare September 17, 2024 13:28
Copy link
Collaborator

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What a huge improvement from what it looked like before in WHCM, oof.

@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch from af7ce27 to 774a7de Compare September 17, 2024 14:33
@cdransf cdransf enabled auto-merge (squash) September 17, 2024 14:33
@cdransf cdransf force-pushed the cdransf/avatar-border-whc-fix branch from 774a7de to 2eb6acd Compare September 17, 2024 15:06
@cdransf cdransf merged commit 00747d0 into main Sep 17, 2024
14 checks passed
@cdransf cdransf deleted the cdransf/avatar-border-whc-fix branch September 17, 2024 15:13
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants