feat(card,contextualhelp,swatch,tokens): add theme tokens for components to global scope #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3246ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-3253--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.30 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailscard
contextualhelp
swatch
tokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-theme-tokens-added
branch
from
2180117
to
ffaafd4
Compare
castastrophe
added
size-3 M
castastrophe
added
skip_vrt
|
VRTs were run and showed no changes |
5t3ph
approved these changes
Oct 15, 2024
castastrophe
force-pushed
the
feat-theme-tokens-added
branch
from
ffaafd4
to
1ac02fa
Compare
|
@5t3ph good point! I updated the commit with spacing fixes. |
5t3ph
approved these changes
Oct 15, 2024
castastrophe
force-pushed
the
feat-theme-tokens-added
branch
from
1ac02fa
to
0ed6328
Compare
cdransf
approved these changes
Oct 17, 2024
castastrophe
force-pushed
the
feat-theme-tokens-added
branch
from
0ed6328
to
f0950da
Compare
pfulton
force-pushed
the
feat-theme-tokens-added
branch
from
f0950da
to
384f4e3
Compare
…nts to global scope
pfulton
force-pushed
the
feat-theme-tokens-added
branch
from
384f4e3
to
c9c5f6f
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@spectrum-css/tokens
Add component-level token overrides from card, contextualhelp, swatch, and typography to ensure valid theme toggling.
Light/dark/darkest custom overrides added:
--spectrum-card-selected-background-color-rgb--spectrum-swatch-border-color--spectrum-swatch-border-color-lightMedium/large custom overrides added:
--spectrum-contextual-help-content-spacingGlobal custom overrides added:
--spectrum-font-family-ar--spectrum-font-family-he--spectrum-font-family--spectrum-font-style--spectrum-font-sizeComponent changes
This update removes tokens defined locally that belonged in the global scope. To ensure no regressions, please upgrade your @spectrum-css/tokens package at the same time so you will pick up the component-level definitions now in the global tokens scope. References to
.spectrum--(light|dark|darkest|medium|large)have been removed.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
To-do list