Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stylelint-badge): create property for forced-colors value to satisfy lint requirements #3265

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 17, 2024

Description

Assigns CanvasText to custom property to satisfy linting requirements.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 17, 2024
@cdransf cdransf self-assigned this Oct 17, 2024
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 5c13b1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/badge Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf added the size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. label Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

🚀 Deployed on https://pr-3265--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 17, 2024

File metrics

Summary

Total size: 4.30 MB*
Total change (Δ): 🔴 ⬆ 0.23 KB (0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
badge 12.12 KB 🔴 ⬆ 0.08 KB

Details

badge

Filename Head Compared to base
index-base.css 12.12 KB 🔴 ⬆ 0.08 KB (0.62%)
index-vars.css 12.12 KB 🔴 ⬆ 0.08 KB (0.62%)
index.css 12.12 KB 🔴 ⬆ 0.08 KB (0.62%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

components/badge/index.css Outdated Show resolved Hide resolved
components/badge/index.css Outdated Show resolved Hide resolved
@cdransf cdransf merged commit 31fdc3b into main Oct 18, 2024
12 checks passed
@cdransf cdransf deleted the cdransf/stylelint-badge-fix branch October 18, 2024 19:33
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants