Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding font families for Arabic and Hebrew. #50

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

tappily
Copy link
Contributor

@tappily tappily commented Dec 12, 2018

Description

Adding language pseudo elements on the root element for Arabic and Hebrew languages. These contain the font family custom properties from DNA.

Related Issue

Motivation and Context

Display all characters within the Myriad (branded sans-serif) font family.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@GarthDB GarthDB self-requested a review December 12, 2018 22:31
Copy link
Member

@GarthDB GarthDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @NateBaldwinDesign and got this cleared up with a vars update.

src/typography/font.css Show resolved Hide resolved
@GarthDB GarthDB merged commit f4dddce into adobe:master Dec 12, 2018
lazd pushed a commit that referenced this pull request Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants