Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation indicator spacing tweaks #211

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Oct 31, 2023

Description

Adjusted navigational indicator spacing tokens to accommodate larger indicator icon sizes.

Token values updated (4):

  • navigational-indicator-top-to-back-icon-small: desktop 7px -> 6px and mobile 9px -> 7px
  • navigational-indicator-top-to-back-icon-medium: desktop 11px -> 9px and mobile 13px -> 12px
  • navigational-indicator-top-to-back-icon-large: desktop 14px -> 12px and mobile 17px -> 16px
  • navigational-indicator-top-to-back-icon-extra-large: desktop 17px -> 15px and mobile 22px -> 19px

Related Issue

DNA-1324

Design motivation

Updated size for the Arrow UI icon used in submenus (previously, it was too small and looked imbalanced relative to everything else)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: 33c85c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Oct 31, 2023

Run report for 0accb693

Total time: 1m 43s | Comparison time: 2m 5s | Estimated savings: 21.5s (17.2% faster)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
🟩 SetupNodeTool(18.13.0) 3.2s Passed
🟩 InstallNodeDeps(18.13.0) 15.4s Passed
🟩 SyncNodeProject(tokens) 0.2ms Passed
🟩 SyncNodeProject(site) 0.2ms Passed
🟩 RunTask(tokens:buildTokens) 32.1s Passed
🟩 RunTask(tokens:buildManifest) 265.3ms Passed
🟩 RunTask(site:copySchema) 54.9ms Passed
🟩 RunTask(tokens:build) 16.3ms Passed
🟩 RunTask(tokens:generateDiffResult) 2s Passed
🟩 RunTask(tokens:test) 43s Passed
🟩 RunTask(site:build) 40.3s Passed
🟩 RunTask(site:clean) 133.3ms Passed
🟩 SyncNodeProject(visualizer) 0.1ms Passed
🟩 RunTask(visualizer:typescript) 3s Passed
🟩 RunTask(site:export) 1.1s Passed
🟩 RunTask(visualizer:build) 3.3s Passed
Touched files
.changeset/neat-weeks-turn.md
.github/workflows/deploy-docs.yml
.github/workflows/release.yml
.moon/toolchain.yml
package.json
packages/tokens/src/layout.json
pnpm-lock.yaml

@GarthDB GarthDB merged commit f50ceea into main Oct 31, 2023
2 checks passed
@GarthDB GarthDB deleted the garthdb/DNA-1324-navigation-indicator branch October 31, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant