Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation indicator spacing tweaks #211

Merged
merged 2 commits into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/neat-weeks-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@adobe/spectrum-tokens": minor
---

Updated size for the Arrow UI icon used in submenus (previously was too small and looked imbalanced relative to everything else)

### Token Diff

_Token values updated (4):_

- `navigational-indicator-top-to-back-icon-small`: `desktop` `7px` -> `6px` and `mobile` `9px` -> `7px`
- `navigational-indicator-top-to-back-icon-medium`: `desktop` `11px` -> `9px` and `mobile` `13px` -> `12px`
- `navigational-indicator-top-to-back-icon-large`: `desktop` `14px` -> `12px` and `mobile` `17px` -> `16px`
- `navigational-indicator-top-to-back-icon-extra-large`: `desktop` `17px` -> `15px` and `mobile` `22px` -> `19px`
2 changes: 1 addition & 1 deletion .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
fetch-depth: 0
- uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.10.0
- uses: moonrepo/setup-moon-action@v1
- run: moon setup
- run: moon run site:export
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fetch-depth: 0
- uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.10.0
- uses: moonrepo/setup-moon-action@v1
- run: moon setup
- run: moon run :build --query "projectSource~packages/*"
Expand Down
2 changes: 1 addition & 1 deletion .moon/toolchain.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ node:

# The version of the package manager (above) to use.
pnpm:
version: "8.9.2"
version: "8.10.0"

# Add `node.version` as a constraint in the root `package.json` `engines`.
addEnginesConstraint: true
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@changesets/cli": "^2.26.2",
"@commitlint/cli": "^17.7.1",
"@commitlint/config-conventional": "^17.7.0",
"@moonrepo/cli": "^1.15.4",
"@moonrepo/cli": "^1.16.0",
"ava": "^5.3.1",
"husky": "^8.0.3",
"lint-staged": "^14.0.1",
Expand All @@ -34,5 +34,5 @@
"engines": {
"node": "18.13.0"
},
"packageManager": "pnpm@8.9.2"
"packageManager": "pnpm@8.10.0"
}
16 changes: 8 additions & 8 deletions packages/tokens/src/layout.json
Original file line number Diff line number Diff line change
Expand Up @@ -1696,47 +1696,47 @@
"navigational-indicator-top-to-back-icon-small": {
"sets": {
"desktop": {
"value": "7px",
"value": "6px",
"uuid": "70de4f97-bc4a-44af-9995-1042e3c7c78f"
},
"mobile": {
"value": "9px",
"value": "7px",
"uuid": "d11ab0de-19bd-4f56-8798-0192fd0cfe0e"
}
}
},
"navigational-indicator-top-to-back-icon-medium": {
"sets": {
"desktop": {
"value": "11px",
"value": "9px",
"uuid": "5561a148-fd77-44d3-b29d-3ed7389122a1"
},
"mobile": {
"value": "13px",
"value": "12px",
"uuid": "74f8a686-0e06-4f7c-9e3d-694749beb420"
}
}
},
"navigational-indicator-top-to-back-icon-large": {
"sets": {
"desktop": {
"value": "14px",
"value": "12px",
"uuid": "c0e06d21-7372-401f-9ec2-926e2b1faf26"
},
"mobile": {
"value": "17px",
"value": "16px",
"uuid": "e84bc865-c89f-403e-bb14-2a11f03fd364"
}
}
},
"navigational-indicator-top-to-back-icon-extra-large": {
"sets": {
"desktop": {
"value": "17px",
"value": "15px",
"uuid": "ac4d18d5-361c-4425-82c3-83979d58f682"
},
"mobile": {
"value": "22px",
"value": "19px",
"uuid": "e68f2798-6a55-499a-b591-0cfc130607ba"
}
}
Expand Down
50 changes: 25 additions & 25 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading