chore: create second-generation world #5785
Draft
+30,814
−9,022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ignore dist folders
27 tasks
* feat(divider): second-gen style migration - clean up css * chore: update first-gen package.json to use base * feat: add static color background decorator - remove static container in favor of using decorator * refactor: simplify null checks * fix: add Storybook styles to fix forced-colors mode rendering * fix: change comment in Divider.ts * chore(divider): add internal docs for static color * docs(divider): correct default size docs --------- Co-authored-by: Marissa Huysentruyt <marissa.huysentruyt@heysparkbox.com>
… architecture (#5800) - create shared types file - import types into core status-light - imports new types in status light base - adds the api overrides for color and semantic variants - adds documentation - ensures the disabled state is not supported in S2 and throws a warning - ensures the disabled property still adds the aria-disabled attribute for S1 - removes disabled logic from base class - ensures the variants values are validated and throws a warning if not * refactor(status-light): status light second-gen - imports new S2 types for colors and semantic variants - adds the api overrides - adds documentation and example usage - refactors template render to use CSS classes and classMap() * refactor(status-light): status light first-gen - imports new S1 types for colors and semantic variants - adds the api overrides and extra disabled property - adds documentation, deprecation notices, and example usage - adds disabled logic to first-gen subclass * feat(status-light): add s2 styles * feat(status-light): add second-gen stories * feat(statuslight): add sizeMap decorator * test(status-light): add dev mode warning tests in first-gen * test(statuslight): add second-gen test file
caseyisonit
added
do-not-merge
feature-branch
2nd gen
* chore: add contributor docs (WIP) * docs: minor edits to contributor docs --------- Co-authored-by: Rúben Carvalho <rubcar@sapo.pt>
…e changeset docs (#5795)
* chore: hoist dev commands to root packagejson * chore: add a root level eslint config file * fix(progress-circle): remove @spectrum-web-component/base dependency from next-gen * chore: update build commands in root packagejson * chore: run hmr on core for storybook and test * chore: fix test command in second-gen and add eslint dev dependency * chore: explicitly run prestorybook in second-gen * chore: update cem analyze command * chore: build ts before storybook in first-gen * chore: hoist license eslint rule to top --------- Co-authored-by: Rúben Carvalho <rubcar@sapo.pt> Co-authored-by: Casey Eickhoff <48574582+caseyisonit@users.noreply.github.com> Co-authored-by: Ruben Carvalho <rcarvalho@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review