feat: added tags to lana logs #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-bogos
added
run-nala
robert-bogos
requested review from
overmyheadandbody,
mokimo and
narcis-radu
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
Codecov Report
@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 95.61% 95.60% -0.02%
==========================================
Files 146 146
Lines 37691 37692 +1
==========================================
- Hits 36038 36034 -4
- Misses 1653 1658 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mokimo
reviewed
Oct 27, 2023
Fixed, I was using another formatter |
mokimo
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Awesome first PR 🚀 If you have issues with the LH score checks, you can also use .live links with published pages - those checks are usually a bit more stable than the .page links since they sit behind a CDN.
One suggestion to keep the code a little leaner. Additionally you could add the tag description to your PR description
// Common used LANA logs tags:
// info - network issues
// warn - authoring related misconfigs or similar
// error - actual error ( ex. cannot read Y of undefind )
// <module> - extra tag to help centralise all logs related to a specific module
amauch-adobe
approved these changes
Oct 27, 2023
skumar09
added
run-nala
narcis-radu
reviewed
Oct 30, 2023
narcis-radu
approved these changes
Oct 30, 2023
mokimo
requested changes
Oct 30, 2023
libs/blocks/global-navigation/features/breadcrumbs/breadcrumbs.js
Outdated
Show resolved
Hide resolved
narcis-radu
approved these changes
Oct 31, 2023
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
overmyheadandbody
approved these changes
Oct 31, 2023
|
mokimo
reviewed
Oct 31, 2023
Comment on lines
+175
to
+178
| await logErrorFor(erroneousFunction, 'message', 'someTags'); | ||
|
|
||
| // Check if lanaLog (through window.lana.log) was called with expected parameters. | ||
| expect(lanaLogSpy.calledOnce).to.be.true; |
There was a problem hiding this comment.
You could expand the check to see that the tags and messages are also correctly called
mokimo
approved these changes
Oct 31, 2023
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
* feat: added tags to lana logs * hotfix: formatting * hotfix: formatting * hotfix: removed composeLanaTags method * hotfix: gnav label for global-navigation * hotfix: send string instead of array to splunk * Update libs/blocks/global-navigation/features/search/gnav-search.js Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * feat: unit test for lana logs --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the requirement of enabling filtering capabilities for Splunk logs based on tags from LANA logs.
Recommended tags:
info- network issueswarn- authoring related misconfigs or similarerror- actual error ( ex. cannot read Y of undefind )<module>- extra tag to help centralise all logs related to a specific moduleRelated Issue
Resolves: MWPW-138031
Testing instructions
lana_nonprodtagskey with an array of strings as value to the json sent as argument for thelanaLogmethodor if you're using the
logErrorFormethod add the array of strings as the third argument ( the strings in the array are the tags that will be associated with the log )E.g.
lanaLog({ message: 'Could not create global navigation.', e, tags: 'errorType=error,module=gnav' });logErrorFor(onToggleClick, 'Toggle click failed', 'errorType=error,module=gnav' ));Screenshots:
Test URLs
Acrobat:
BACOM:
CC:
Milo: