MWPW-142003: Mini Compare Chart Mobile styling #1887
Conversation
Axelcureno
added
bug
There was a problem hiding this comment.
I think, we could achieve this as follows at the line 404.
const container = el.closest('main > div');
or
const container = document.querySelector('main');. (main one should be done only once)
Please try that first, I would like us to avoid event listeners as much as possible.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #1887 +/- ##
==========================================
- Coverage 96.29% 96.29% -0.01%
==========================================
Files 165 165
Lines 42285 42301 +16
==========================================
+ Hits 40718 40733 +15
- Misses 1567 1568 +1 ☔ View full report in Codecov by Sentry. |
@yesil I agree we should avoid event listeners. Unfortunately, I tried both approaches and none worked. |
Axelcureno
requested review from
yesil,
npeltier,
honstar,
ryanmparrish,
3ch023,
vladen and
VKniaz
|
@Roycethan can you please verify this one? |
@Axelcureno Plz review these issues:
2)Not sure if this device is in scope but just adding here for this resolution - left/right broders:
|
|
Co-Authored-By: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-Authored-By: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-Authored-By: ilyas Stéphane Türkben <isturkben@gmail.com>
* MWPW-142003: Mini Compare Chart Mobile styling --------- Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Introduces mobile styles for Mini Compare Chart card and an event listener for tab button clicks in order to trigger resize the cards not showing in the DOM.
Tacocat PR-related: https://git.corp.adobe.com/wcms/tacocat.js/pull/538
Resolves: MWPW-142003
Test URLs: