Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-142003: Mini Compare Chart Mobile styling #1989

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Mar 11, 2024

Introduces mobile styles for Mini Compare Chart card and an event listener for tab button clicks in order to trigger resize the cards not showing in the DOM.

Screenshot 2024-02-13 at 12 31 12 PM
Screenshot 2024-02-13 at 12 31 02 PM

Tacocat PR-related: https://git.corp.adobe.com/wcms/tacocat.js/pull/538

(resubmitted PR

Resolves: MWPW-142003 and MWPW-142876

Test URLs:

@Axelcureno Axelcureno added bug Something isn't working run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer merch card labels Mar 11, 2024
@Axelcureno Axelcureno self-assigned this Mar 11, 2024
@Axelcureno Axelcureno requested a review from a team as a code owner March 11, 2024 20:10
Copy link
Contributor

aem-code-sync bot commented Mar 11, 2024

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (7af20af) to head (37c95d3).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #1989      +/-   ##
==========================================
+ Coverage   96.28%   96.31%   +0.03%     
==========================================
  Files         166      166              
  Lines       42324    42329       +5     
==========================================
+ Hits        40751    40769      +18     
+ Misses       1573     1560      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roycethan
Copy link

Roycethan commented Mar 11, 2024

@Axelcureno Reviewing https://main--dc--adobecom.hlx.page/dc-shared/fragments/merch-cards/acrobat-business?milolibs=MWPW-142003--milo--axelcureno few observations noting here:
image

1)Mobile: Left/Right padding for pricing text is correct ( expected: 16 px) where as for body text its 24 px and CTA its 8 px
2)Mobile:Theres additional padding below the Buy now CTA
3)Mobile: In the Pricing text the right padding is less or the string "per" is overflown
4)Mobile: In the quantity selector dropdown the the numbers are center algined - not sure if they have to be left aligned?
5)Mobile: Icons in the chat needs to be hidden in mobile view ?
Also tablet styles need to be adjusted if its applicable to this PR, didn't see picker and tabs to check re-size

@Axelcureno
Copy link
Member Author

@Axelcureno Reviewing https://mwpw-142003--milo--axelcureno.hlx.page/drafts/axel/block-samples/fragments/mini-compare-chart few observations noting here:

  1. Mobile: CTA text is not center aligned
    2)Mobile: Left/Right padding for pricing text is correct ( expected: 16 px) where as for body text its 24 px and CTA its 8 px
    3)Mobile:Theres additional padding below the free-trial CTA
    4)Mobile: thre's also an unwanted 16 px padding between Pricing text and promo text
    Also tablet styles need to be adjusted if its applicable to this PR, didn't see picker and tabs to check re-size

@Roycethan please make sure to refresh the page if testing in mobile or resizing the page since this card requires manual resizing by JS code.
I also recommend to test from this URL to get a more realistic view https://main--dc--adobecom.hlx.page/dc-shared/fragments/merch-cards/acrobat-business?milolibs=MWPW-142003--milo--axelcureno since milo-forked URLs do not resolve offers (CORS issue) (prices, quantity selectos and offer selectors) causing extra space to show.
Also please note that as per the requirement (mentioned in the ticket) each element inside the card should be perfectly aligned horizontally, which can cause extra space to be added in some cards. The padding values (16px or 24px) are assumed if all cards have the same lenght of content.

@Roycethan
Copy link

@Axelcureno Reviewing https://mwpw-142003--milo--axelcureno.hlx.page/drafts/axel/block-samples/fragments/mini-compare-chart few observations noting here:

  1. Mobile: CTA text is not center aligned
    2)Mobile: Left/Right padding for pricing text is correct ( expected: 16 px) where as for body text its 24 px and CTA its 8 px
    3)Mobile:Theres additional padding below the free-trial CTA
    4)Mobile: thre's also an unwanted 16 px padding between Pricing text and promo text
    Also tablet styles need to be adjusted if its applicable to this PR, didn't see picker and tabs to check re-size

@Roycethan please make sure to refresh the page if testing in mobile or resizing the page since this card requires manual resizing by JS code. I also recommend to test from this URL to get a more realistic view https://main--dc--adobecom.hlx.page/dc-shared/fragments/merch-cards/acrobat-business?milolibs=MWPW-142003--milo--axelcureno since milo-forked URLs do not resolve offers (CORS issue) (prices, quantity selectos and offer selectors) causing extra space to show. Also please note that as per the requirement (mentioned in the ticket) each element inside the card should be perfectly aligned horizontally, which can cause extra space to be added in some cards. The padding values (16px or 24px) are assumed if all cards have the same lenght of content.

@Axelcureno Updated my comments based on the above url which i checked for standard mobile resolution say Iphone 12 pro 390*844 px plz review thanks

@VKniaz
Copy link
Contributor

VKniaz commented Mar 12, 2024

Please add tests.

@Axelcureno Axelcureno requested a review from yesil March 13, 2024 14:50
Copy link
Contributor

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the lint and unit test issues are fixed, it is good to merge for me.

test/blocks/merch-card/merch-card-observer.test.js Outdated Show resolved Hide resolved
@afmicka
Copy link
Contributor

afmicka commented Mar 14, 2024

@Axelcureno

  1. It was mentioned early on in the jira comments that mobile view looks different by specs. It seems that there should be one card per row instead of 2 very narrow (a bit weird looking) ones. :) I see that people are waiting for someone to be back from PTO next week to review the work for mobile but still.. this is kind of obvious.

Aside of that (if we want to proceed as is):
2. Padding on the right for the prices does not seem correct. The word 'per' is almost out of the card boundaries on iPhone 12 Pro.
3. Way too much padding around CTA (above and below) on the third card that ended up in the new row. Should that be like that - aligning all the paddings to the cards in the previous row?
4. Paddings are messed up on kitchen-sync on all views including desktop. Could you please review those (see screenshot)?
cc: @Roycethan

Screenshot 2024-03-14 at 14 12 40 Screenshot 2024-03-14 at 13 57 32 Screenshot 2024-03-14 at 14 02 58 Screenshot 2024-03-14 at 14 00 51

Co-Authored-By: ilyas Stéphane Türkben <isturkben@gmail.com>
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left/right padding is fixed/ pricing alignment is fixed,
Discussed with @Axelcureno regarding additional padding around pricing and CTA's which as per him causing due to making CT's and prices in line with other cards - and the layout is being approved by stakeholders, Per this agreement approving this.

@Roycethan Roycethan removed the needs-verification PR requires E2E testing by a reviewer label Mar 14, 2024
@Roycethan Roycethan added the verified PR has been E2E tested by a reviewer label Mar 14, 2024
@Blainegunn Blainegunn merged commit 944ae19 into adobecom:stage Mar 18, 2024
8 checks passed
Blainegunn added a commit that referenced this pull request Mar 19, 2024
Blainegunn added a commit that referenced this pull request Mar 19, 2024
Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)"

This reverts commit 944ae19.
Blainegunn added a commit that referenced this pull request Mar 19, 2024
* MWPW-143648 - [Action Item] Fix float icon position (#1957)

* display main image block and add inline flex to floated icon

* revert inline flex rull on floated icon

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946)

fixed height auto adjustment and iframe styles in modal

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Fix for commerce modal height (#2014)

There's a potential CSO lurking

* [MWPW-144516] Handle cross cloud menu block error (#2006)

* fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901)

* MWPW-142248

* fixed linting errors

* revert package.json

* revert package_lock.json

* Accessibility for the show-x variants of carousel

* test cases for code coverage

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016)

fixed CSS selector commerce-frame section and fragment

* Sync stage with main (#2025)

* [Release] Stage to Main (#2005)

MWPW-143673: Load Milo fragment modals from co links #1972
MWPW-142894: fragments can lead to invalid html #1937
High Priority
Caas-Marquee: Fixes integration with martech.js issues #2003
MWPW-143591 Fix Contextual Search Duplicates #1990
Zero Impact
MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002
---------
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2010)


* Update martech.main.standard.min.js (#2008)

---------
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* fix merge empty line

---------

Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* remove extra line

* MWPW-144575: fix for the modal duplication (#2021)

added checking to not create a modal when it is already present in DOM

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996)

* Host imslib from milo libs/deps

* Fix formatting

* Minor script cleanup

* wp

* Serve ims, launch & launch development locally. Rewrite the workflow

* Remove launch dependency for now

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142003: Mini Compare Chart Mobile styling (#1989)

Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-143202 firefox gnav not appearing bug (#1969)

* try to catch error

* test without breaking things

* catch akamai failure

* add try catch

* attempt 2 to catch jsonp failure

* cleanup

* fix geo2 source

* test using proper fetch

* MWPW-143202 remove old jsonp request

* MWPW-143202 catch case if resp is not ok

* MWPW-143202 prevent caching of geo2 request

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Excluding modals from Active link check (#1942)

* Fix: Excluding modals from Active link check

---------

Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* [MWPW-144602] Ensure DNT functionality in top nav (#2020)

* Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041)

Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)"

This reverts commit 944ae19.

---------

Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>
Blainegunn added a commit that referenced this pull request Mar 20, 2024
* MWPW-143648 - [Action Item] Fix float icon position (#1957)

* display main image block and add inline flex to floated icon

* revert inline flex rull on floated icon

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946)

fixed height auto adjustment and iframe styles in modal

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Fix for commerce modal height (#2014)

There's a potential CSO lurking

* [MWPW-144516] Handle cross cloud menu block error (#2006)

* fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901)

* MWPW-142248

* fixed linting errors

* revert package.json

* revert package_lock.json

* Accessibility for the show-x variants of carousel

* test cases for code coverage

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016)

fixed CSS selector commerce-frame section and fragment

* Sync stage with main (#2025)

* [Release] Stage to Main (#2005)

MWPW-143673: Load Milo fragment modals from co links #1972
MWPW-142894: fragments can lead to invalid html #1937
High Priority
Caas-Marquee: Fixes integration with martech.js issues #2003
MWPW-143591 Fix Contextual Search Duplicates #1990
Zero Impact
MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002
---------
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2010)


* Update martech.main.standard.min.js (#2008)

---------
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* fix merge empty line

---------

Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* remove extra line

* MWPW-144575: fix for the modal duplication (#2021)

added checking to not create a modal when it is already present in DOM

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996)

* Host imslib from milo libs/deps

* Fix formatting

* Minor script cleanup

* wp

* Serve ims, launch & launch development locally. Rewrite the workflow

* Remove launch dependency for now

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142003: Mini Compare Chart Mobile styling (#1989)

Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-143202 firefox gnav not appearing bug (#1969)

* try to catch error

* test without breaking things

* catch akamai failure

* add try catch

* attempt 2 to catch jsonp failure

* cleanup

* fix geo2 source

* test using proper fetch

* MWPW-143202 remove old jsonp request

* MWPW-143202 catch case if resp is not ok

* MWPW-143202 prevent caching of geo2 request

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Excluding modals from Active link check (#1942)

* Fix: Excluding modals from Active link check

---------

Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* [MWPW-144602] Ensure DNT functionality in top nav (#2020)

* Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041)

Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)"

This reverts commit 944ae19.

* MWPW-144026 Update Twitter Icon to X (#2030)

* Add support for bold as header if no header (#1997)

* Add support for bold as header if no header

* Add tracking to modal close button

* separate branches

* moving if on strong or B

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* [MWPW-144112] send-to-caas: point to prod end-point (#1995)

[MWPW-144112] point to prod end-point

* [MILO] Allow svg or media files to be located in a fragments folder (#1966)

* fix if svg is located in fragments folder

* update to handle any file that is not a fragment

* unit test

* better placement

* update existing file reference

no idea how this was working with the incorrect reference

* add carve out for mp4

Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached

* save match result so I do not have to match twice

* update nameSplit to hasExtension per Slack request

* update hasExtension to use include instead of length

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Consolidate MEP PR's for stage (#1975)

* stash

* start retro support (need to adjust replacefragment)

* save progress

* progress

* stash

* solid state

* reverse mep preview check

* update file for insertScript

* organized unit test files

* unit tests working

* remove file added by override

* add coverage to unit test

* PR comments

* use "section" to mean "section1"

* no longer need to pass mep to handleFragmentCommand

* Update libs/features/personalization/personalization.js

Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* Update libs/features/personalization/personalization.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* add replace action with fragment selector not on page

* moving fragment that's not page unit test

* [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980)

* new branch to separate my updates from others

* export matchGlob

* see if removing matchGlob fixes unit test

* found unit test issue

* stash

* unit test repair

* increase coverage

* stop loading disabled promos

* update unit test

* only download disabled manifests if needed

* [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992)

* change delimiter to ---

* update unit tests

* Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959)

* WIP

* Add tests

* stash

* stash

* stash

* merge select functions

* unit tests fixed

* fix for test or promo type

* create unit test file

* fix unit test error

* unit tests

* improve merge of duplicate manifests

* fix merge of Target with fresh manifest, add unit test

* new branch to separate my updates from others

* export matchGlob

* see if removing matchGlob fixes unit test

* found unit test issue

* stash

* unit test repair

* increase coverage

* merge conflicts

* remove duplicate from merge

* remove another duplicate from merge

---------

Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com>

* more duplicates

* move normalization of manifestPath to before getting variant

* Unit test repair

* repair utils unit test

* only update path if needed

* force update sample scripts

* trigger try/catch

---------

Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* UAR integration - Quiz Sync for state in local storage and accessibility (#2032)

* MWPW-139939 - Support for quiz state in local storage (#1956)

* MWPW-139939 - Support for quiz state in local storage

* Renders the quiz at any point as captured in local storage

Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939)

* fix for no stored-quiz-state

* remove stored quiz data when advancing to the next quiz step via handleOnNextClick()

* stored quiz state unit tests

* MWPW-143799 - Quiz Accessibility Refinement (#2004)

* Add id to the h1
* set role and aria-labelledby on the option container
* swap to role-checkbox and aria-checked for option buttons
* use disabled instead of tabindex -1
Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799)

---------

Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: jedjedjedM <93785811+jedjedjedM@users.noreply.github.com>
Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com>
Co-authored-by: Victor Hargrave <vhargrave@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working commerce merch card Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants