Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions #2016

Merged
merged 1 commit into from
Mar 15, 2024
Merged

MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions #2016

merged 1 commit into from
Mar 15, 2024

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Mar 15, 2024 •
edited by yesil
Loading

This is a fix for recently merged changes, where the wrong CSS selector caused the .section height in commerce-frame modals to be 0 instead of 100%, which resulted in no content shown on desktop resolution.

Resolves: MWPW-144575

Test URLs:

Other test URLs

@mirafedas mirafedas added @modal Run Modal Tests Nala needs-verification PR requires E2E testing by a reviewer labels Mar 15, 2024
@mirafedas mirafedas requested a review from Axelcureno March 15, 2024 08:58
@mirafedas mirafedas force-pushed the MWPW-144575-modal-section-height branch from 830d442 to b0ab706 Compare March 15, 2024 09:00
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (d01ffb5) to head (1018a6d).
Report is 304 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #2016      +/-   ##
==========================================
+ Coverage   95.57%   96.30%   +0.72%     
==========================================
  Files         148      166      +18     
  Lines       38148    42300    +4152     
==========================================
+ Hits        36460    40735    +4275     
+ Misses       1688     1565     -123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirafedas mirafedas force-pushed the MWPW-144575-modal-section-height branch from b0ab706 to 129086c Compare March 15, 2024 09:06
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Mar 15, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/mirafedas/showdelayedmodalhere PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mirafedas mirafedas force-pushed the MWPW-144575-modal-section-height branch from c7aae99 to b985de5 Compare March 15, 2024 09:26
@mirafedas mirafedas requested a review from a team as a code owner March 15, 2024 10:37
@mirafedas mirafedas force-pushed the MWPW-144575-modal-section-height branch from 00c966a to 1018a6d Compare March 15, 2024 11:24
@3ch023 3ch023 added the run-nala Run Nala Test Automation against PR label Mar 15, 2024
@afmicka afmicka added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Mar 15, 2024
@yesil yesil merged commit 52bb962 into adobecom:stage Mar 15, 2024
19 checks passed
@yesil yesil added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Mar 15, 2024
@yesil
Copy link
Contributor

yesil commented Mar 15, 2024

Added high prio because this will fix an issue with some modals in production.

@yesil yesil mentioned this pull request Mar 15, 2024
Merged
yesil pushed a commit to yesil/milo that referenced this pull request Mar 18, 2024
@mirafedas @yesil
MWPW-144575: Modal-Iframe for apps-whats-included is broken for Deskt…
94dee45 
…op resolutions (adobecom#2016)

fixed CSS selector commerce-frame section and fragment
yesil pushed a commit to yesil/milo that referenced this pull request Mar 18, 2024
@mirafedas @yesil
MWPW-144575: Modal-Iframe for apps-whats-included is broken for Deskt…
02a9a1a 
…op resolutions (adobecom#2016)

fixed CSS selector commerce-frame section and fragment
Blainegunn added a commit that referenced this pull request Mar 18, 2024
@yesil @Sartxi
@Blainegunn @mirafedas @Axelcureno @overmyheadandbody @sharath-kannan @robert-bogos @vhargrave @thedoc31 @meganthecoder @cmiqueo
[Release] Stage to Main (#2019)
2144700 
* MWPW-143648 - [Action Item] Fix float icon position (#1957)

* display main image block and add inline flex to floated icon

* revert inline flex rull on floated icon

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946)

fixed height auto adjustment and iframe styles in modal

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Fix for commerce modal height (#2014)

There's a potential CSO lurking

* [MWPW-144516] Handle cross cloud menu block error (#2006)

* fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901)

* MWPW-142248

* fixed linting errors

* revert package.json

* revert package_lock.json

* Accessibility for the show-x variants of carousel

* test cases for code coverage

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016)

fixed CSS selector commerce-frame section and fragment

* Sync stage with main (#2025)

* [Release] Stage to Main (#2005)

MWPW-143673: Load Milo fragment modals from co links #1972
MWPW-142894: fragments can lead to invalid html #1937
High Priority
Caas-Marquee: Fixes integration with martech.js issues #2003
MWPW-143591 Fix Contextual Search Duplicates #1990
Zero Impact
MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002
---------
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2010)


* Update martech.main.standard.min.js (#2008)

---------
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* fix merge empty line

---------

Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* remove extra line

* MWPW-144575: fix for the modal duplication (#2021)

added checking to not create a modal when it is already present in DOM

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

---------

Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
Blainegunn added a commit that referenced this pull request Mar 19, 2024
@Blainegunn @Sartxi
@mirafedas @Axelcureno @overmyheadandbody @sharath-kannan @robert-bogos @vhargrave @yesil @thedoc31 @meganthecoder @cmiqueo @mokimo @bandana147
[Release] Stage to Main (#2042)
2ccada7 
* MWPW-143648 - [Action Item] Fix float icon position (#1957)

* display main image block and add inline flex to floated icon

* revert inline flex rull on floated icon

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946)

fixed height auto adjustment and iframe styles in modal

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Fix for commerce modal height (#2014)

There's a potential CSO lurking

* [MWPW-144516] Handle cross cloud menu block error (#2006)

* fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901)

* MWPW-142248

* fixed linting errors

* revert package.json

* revert package_lock.json

* Accessibility for the show-x variants of carousel

* test cases for code coverage

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016)

fixed CSS selector commerce-frame section and fragment

* Sync stage with main (#2025)

* [Release] Stage to Main (#2005)

MWPW-143673: Load Milo fragment modals from co links #1972
MWPW-142894: fragments can lead to invalid html #1937
High Priority
Caas-Marquee: Fixes integration with martech.js issues #2003
MWPW-143591 Fix Contextual Search Duplicates #1990
Zero Impact
MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002
---------
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2010)


* Update martech.main.standard.min.js (#2008)

---------
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* fix merge empty line

---------

Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* remove extra line

* MWPW-144575: fix for the modal duplication (#2021)

added checking to not create a modal when it is already present in DOM

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996)

* Host imslib from milo libs/deps

* Fix formatting

* Minor script cleanup

* wp

* Serve ims, launch & launch development locally. Rewrite the workflow

* Remove launch dependency for now

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142003: Mini Compare Chart Mobile styling (#1989)

Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-143202 firefox gnav not appearing bug (#1969)

* try to catch error

* test without breaking things

* catch akamai failure

* add try catch

* attempt 2 to catch jsonp failure

* cleanup

* fix geo2 source

* test using proper fetch

* MWPW-143202 remove old jsonp request

* MWPW-143202 catch case if resp is not ok

* MWPW-143202 prevent caching of geo2 request

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Excluding modals from Active link check (#1942)

* Fix: Excluding modals from Active link check

---------

Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* [MWPW-144602] Ensure DNT functionality in top nav (#2020)

* Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041)

Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)"

This reverts commit 944ae19.

---------

Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>
Blainegunn added a commit that referenced this pull request Mar 20, 2024
@Blainegunn @Sartxi
@mirafedas @Axelcureno @overmyheadandbody @sharath-kannan @robert-bogos @vhargrave @yesil @thedoc31 @meganthecoder @cmiqueo @mokimo @bandana147 @vgoodric @jedjedjedM @vivgoodrich @chrischrischris @github-actions @colloyd
[Release] Stage to Main (#2043)
b19efef 
* MWPW-143648 - [Action Item] Fix float icon position (#1957)

* display main image block and add inline flex to floated icon

* revert inline flex rull on floated icon

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946)

fixed height auto adjustment and iframe styles in modal

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Fix for commerce modal height (#2014)

There's a potential CSO lurking

* [MWPW-144516] Handle cross cloud menu block error (#2006)

* fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901)

* MWPW-142248

* fixed linting errors

* revert package.json

* revert package_lock.json

* Accessibility for the show-x variants of carousel

* test cases for code coverage

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016)

fixed CSS selector commerce-frame section and fragment

* Sync stage with main (#2025)

* [Release] Stage to Main (#2005)

MWPW-143673: Load Milo fragment modals from co links #1972
MWPW-142894: fragments can lead to invalid html #1937
High Priority
Caas-Marquee: Fixes integration with martech.js issues #2003
MWPW-143591 Fix Contextual Search Duplicates #1990
Zero Impact
MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002
---------
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2010)


* Update martech.main.standard.min.js (#2008)

---------
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* fix merge empty line

---------

Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* remove extra line

* MWPW-144575: fix for the modal duplication (#2021)

added checking to not create a modal when it is already present in DOM

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996)

* Host imslib from milo libs/deps

* Fix formatting

* Minor script cleanup

* wp

* Serve ims, launch & launch development locally. Rewrite the workflow

* Remove launch dependency for now

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-142003: Mini Compare Chart Mobile styling (#1989)

Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-143202 firefox gnav not appearing bug (#1969)

* try to catch error

* test without breaking things

* catch akamai failure

* add try catch

* attempt 2 to catch jsonp failure

* cleanup

* fix geo2 source

* test using proper fetch

* MWPW-143202 remove old jsonp request

* MWPW-143202 catch case if resp is not ok

* MWPW-143202 prevent caching of geo2 request

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Excluding modals from Active link check (#1942)

* Fix: Excluding modals from Active link check

---------

Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* [MWPW-144602] Ensure DNT functionality in top nav (#2020)

* Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041)

Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)"

This reverts commit 944ae19.

* MWPW-144026 Update Twitter Icon to X (#2030)

* Add support for bold as header if no header (#1997)

* Add support for bold as header if no header

* Add tracking to modal close button

* separate branches

* moving if on strong or B

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* [MWPW-144112] send-to-caas: point to prod end-point (#1995)

[MWPW-144112] point to prod end-point

* [MILO] Allow svg or media files to be located in a fragments folder (#1966)

* fix if svg is located in fragments folder

* update to handle any file that is not a fragment

* unit test

* better placement

* update existing file reference

no idea how this was working with the incorrect reference

* add carve out for mp4

Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached

* save match result so I do not have to match twice

* update nameSplit to hasExtension per Slack request

* update hasExtension to use include instead of length

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Consolidate MEP PR's for stage (#1975)

* stash

* start retro support (need to adjust replacefragment)

* save progress

* progress

* stash

* solid state

* reverse mep preview check

* update file for insertScript

* organized unit test files

* unit tests working

* remove file added by override

* add coverage to unit test

* PR comments

* use "section" to mean "section1"

* no longer need to pass mep to handleFragmentCommand

* Update libs/features/personalization/personalization.js

Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* Update libs/features/personalization/personalization.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* add replace action with fragment selector not on page

* moving fragment that's not page unit test

* [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980)

* new branch to separate my updates from others

* export matchGlob

* see if removing matchGlob fixes unit test

* found unit test issue

* stash

* unit test repair

* increase coverage

* stop loading disabled promos

* update unit test

* only download disabled manifests if needed

* [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992)

* change delimiter to ---

* update unit tests

* Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959)

* WIP

* Add tests

* stash

* stash

* stash

* merge select functions

* unit tests fixed

* fix for test or promo type

* create unit test file

* fix unit test error

* unit tests

* improve merge of duplicate manifests

* fix merge of Target with fresh manifest, add unit test

* new branch to separate my updates from others

* export matchGlob

* see if removing matchGlob fixes unit test

* found unit test issue

* stash

* unit test repair

* increase coverage

* merge conflicts

* remove duplicate from merge

* remove another duplicate from merge

---------

Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com>

* more duplicates

* move normalization of manifestPath to before getting variant

* Unit test repair

* repair utils unit test

* only update path if needed

* force update sample scripts

* trigger try/catch

---------

Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* UAR integration - Quiz Sync for state in local storage and accessibility (#2032)

* MWPW-139939 - Support for quiz state in local storage (#1956)

* MWPW-139939 - Support for quiz state in local storage

* Renders the quiz at any point as captured in local storage

Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939)

* fix for no stored-quiz-state

* remove stored quiz data when advancing to the next quiz step via handleOnNextClick()

* stored quiz state unit tests

* MWPW-143799 - Quiz Accessibility Refinement (#2004)

* Add id to the h1
* set role and aria-labelledby on the option container
* swap to role-checkbox and aria-checked for option buttons
* use disabled instead of tabindex -1
Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799)

---------

Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com>
Co-authored-by: J. Casalino <casalino@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: jedjedjedM <93785811+jedjedjedM@users.noreply.github.com>
Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com>
Co-authored-by: Victor Hargrave <vhargrave@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3ch023 3ch023 3ch023 approved these changes

@yesil yesil yesil approved these changes

@Axelcureno Axelcureno Awaiting requested review from Axelcureno

@vladen vladen Awaiting requested review from vladen

@bozojovicic bozojovicic Awaiting requested review from bozojovicic

@VKniaz VKniaz Awaiting requested review from VKniaz

Assignees
No one assigned
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? @modal Run Modal Tests Nala Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirafedas @yesil @3ch023 @afmicka