[MWPW-137148] [PERFORMANCE] Load IMS from the same domain #1996

mokimo · 2024-03-12T18:45:10Z

Description

Selfhost IMS to avoid DNS lookups wasting precious time for visitors.
Check for a new version of imslib.min.js every 24h and automatically create a PR on updates (see example) based on the last modified date of the resource

Related Issue

Resolves: MWPW-137148

Testing instructions

Signing in should still function
Signing out should still work
Regression tests on all consumers for IMS related functionality

Runnings this action locally

Development can be cumbersome, for this reason you can also run this on your local environment using node.

create a .env file on the root of your repo with GH_TOKEN, REPO_OWNER, REPO_NAME, LOCAL_RUN=true & if you want to test the workflow for a script other than IMS, you can set a few more configs.

GH_TOKEN= // https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens
REPO_OWNER=mokimo
REPO_NAME=milo
LOCAL_RUN=true
LOCAL_RUN_ORIGIN=mokimo
LOCAL_RUN_BRANCH=test_runs
LOCAL_RUN_SCRIPT=https://assets.adobedtm.com/d4d114c60e50/a0e989131fd5/launch-a27b33fc2dc0-development.min.js
LOCAL_RUN_SCRIPT_PATH=./libs/deps/launch-a27b33fc2dc0-development.min.js
LOCAL_RUN_TITLTE=[AUTOMATED-PR] Update launch prod dependency

run node --env-file=.env .github/workflows/update-script.js

Test URLs

Acrobat:

BACOM:

CC:

Homepage:

Blog:

Milo:

codecov · 2024-03-12T18:48:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (9754674) to head (6344c13).
Report is 2 commits behind head on stage.

❗ Current head 6344c13 differs from pull request most recent head 8762345. Consider uploading reports for the commit 8762345 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #1996      +/-   ##
==========================================
+ Coverage   96.29%   96.32%   +0.03%     
==========================================
  Files         166      165       -1     
  Lines       42324    42274      -50     
==========================================
- Hits        40754    40721      -33     
+ Misses       1570     1553      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aem-code-sync · 2024-03-12T18:51:21Z

Page	Scores	Audits	Google
/drafts/ramuntea/gnav-refactor?martech=off

JasonHowellSlavin

Awesome! Looks good. Do we need to update any tests for checking that IMS is coming from the right place.

This saves a lot of load time on slow networks. Thank you for tackling this!

overmyheadandbody

Amazing job on streamlining this! This might be useful for other dependencies as well. We should wait to see it in action and figure out any quirks and then maybe open up a discussion documenting the approach for other to use.

.github/workflows/update-ims.js

mokimo · 2024-03-13T15:39:16Z

As discussed with @chrischrischris we also want to self-host https://github.com/adobecom/milo/blob/stage/libs/martech/martech.js#L102 for more performance gains. Ben/Bhim/Uma will internally discuss this and a test environment can be seen here

The code is ready to check for an abritary dependency, not limited to IMS.

overmyheadandbody

❤️

overmyheadandbody · 2024-03-14T10:37:11Z

.github/workflows/localWorkflowConfigs.js

+
+  const { Octokit } = require('@octokit/rest');
+  return {
+    github: { rest: new Octokit({ auth: process.env.GH_TOKEN }) },


I'm guessing this can just be auth, since you declare it on L5?

SilviuLCF

Ready to STAGE

Testing details
https://jira.corp.adobe.com/browse/MWPW-137148

narcis-radu

Great work on this, I'm super excited to see the results.

narcis-radu · 2024-03-18T15:35:04Z

.github/workflows/update-script.js

+    execSyncSafe(`git branch -D ${branch}`);
+    execSync(`git checkout -b ${branch}`);
+  }
+  console.log('writing script to file', scriptPath);


Should imslib.min.js be updated when running on local? I'm thinking the source of truth should be the upstream project to make sure we're consistent.

narcis-radu · 2024-03-18T15:39:21Z

.github/workflows/update-script.js

+const getPrDescription = ({ branch, scriptPath }) => `## Description
+Update ${scriptPath} to the latest version
+## Related Issue
+Resolves: NO TICKET - AUTOMATED CREATED PR.


Can we link to a wiki page or discussion? It should be easier for folks to understand the details.

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. * MWPW-144026 Update Twitter Icon to X (#2030) * Add support for bold as header if no header (#1997) * Add support for bold as header if no header * Add tracking to modal close button * separate branches * moving if on strong or B --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * [MWPW-144112] send-to-caas: point to prod end-point (#1995) [MWPW-144112] point to prod end-point * [MILO] Allow svg or media files to be located in a fragments folder (#1966) * fix if svg is located in fragments folder * update to handle any file that is not a fragment * unit test * better placement * update existing file reference no idea how this was working with the incorrect reference * add carve out for mp4 Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached * save match result so I do not have to match twice * update nameSplit to hasExtension per Slack request * update hasExtension to use include instead of length --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Consolidate MEP PR's for stage (#1975) * stash * start retro support (need to adjust replacefragment) * save progress * progress * stash * solid state * reverse mep preview check * update file for insertScript * organized unit test files * unit tests working * remove file added by override * add coverage to unit test * PR comments * use "section" to mean "section1" * no longer need to pass mep to handleFragmentCommand * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add replace action with fragment selector not on page * moving fragment that's not page unit test * [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980) * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests * Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959) * WIP * Add tests * stash * stash * stash * merge select functions * unit tests fixed * fix for test or promo type * create unit test file * fix unit test error * unit tests * improve merge of duplicate manifests * fix merge of Target with fresh manifest, add unit test * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * merge conflicts * remove duplicate from merge * remove another duplicate from merge --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * more duplicates * move normalization of manifestPath to before getting variant * Unit test repair * repair utils unit test * only update path if needed * force update sample scripts * trigger try/catch --------- Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * UAR integration - Quiz Sync for state in local storage and accessibility (#2032) * MWPW-139939 - Support for quiz state in local storage (#1956) * MWPW-139939 - Support for quiz state in local storage * Renders the quiz at any point as captured in local storage Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939) * fix for no stored-quiz-state * remove stored quiz data when advancing to the next quiz step via handleOnNextClick() * stored quiz state unit tests * MWPW-143799 - Quiz Accessibility Refinement (#2004) * Add id to the h1 * set role and aria-labelledby on the option container * swap to role-checkbox and aria-checked for option buttons * use disabled instead of tabindex -1 Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799) --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: jedjedjedM <93785811+jedjedjedM@users.noreply.github.com> Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com>

mokimo added 3 commits March 12, 2024 19:11

Host imslib from milo libs/deps

059ff46

Fix formatting

8c1987b

Minor script cleanup

2e81b66

mokimo requested a review from a team as a code owner March 12, 2024 18:45

mokimo added the needs-verification PR requires E2E testing by a reviewer label Mar 12, 2024

mokimo requested review from narcis-radu, overmyheadandbody and robert-bogos March 12, 2024 18:50

mokimo assigned SilviuLCF Mar 12, 2024

JasonHowellSlavin approved these changes Mar 12, 2024

View reviewed changes

overmyheadandbody approved these changes Mar 13, 2024

View reviewed changes

.github/workflows/update-ims.js Outdated Show resolved Hide resolved

.github/workflows/update-ims.js Outdated Show resolved Hide resolved

.github/workflows/update-ims.js Outdated Show resolved Hide resolved

.github/workflows/update-ims.js Outdated Show resolved Hide resolved

wp

a5f2019

mokimo changed the title ~~[MWPW-137148] [PERFORMANCE] Load IMS from the same domain~~ [MWPW-137148] [PERFORMANCE] Load IMS & Launch from the same domain Mar 13, 2024

Serve ims, launch & launch development locally. Rewrite the workflow

be05c54

mokimo requested review from overmyheadandbody and chrischrischris March 13, 2024 20:22

Remove launch dependency for now

6344c13

mokimo changed the title ~~[MWPW-137148] [PERFORMANCE] Load IMS & Launch from the same domain~~ [MWPW-137148] [PERFORMANCE] Load IMS from the same domain Mar 14, 2024

overmyheadandbody approved these changes Mar 14, 2024

View reviewed changes

robert-bogos approved these changes Mar 15, 2024

View reviewed changes

SilviuLCF self-requested a review March 15, 2024 10:57

SilviuLCF approved these changes Mar 15, 2024

View reviewed changes

SilviuLCF added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Mar 15, 2024

narcis-radu reviewed Mar 18, 2024

View reviewed changes

Merge branch 'stage' into mwpw-137148-same-domain-ims

8762345

Blainegunn merged commit 32959b6 into adobecom:stage Mar 18, 2024
9 checks passed

This was referenced Mar 18, 2024

[Release] Stage to Main #2029

Closed

[Release] Stage to Main #2042

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MWPW-137148] [PERFORMANCE] Load IMS from the same domain #1996

[MWPW-137148] [PERFORMANCE] Load IMS from the same domain #1996

mokimo commented Mar 12, 2024 •

edited

Loading

codecov bot commented Mar 12, 2024 •

edited

Loading

aem-code-sync bot commented Mar 12, 2024 •

edited

Loading

JasonHowellSlavin left a comment

overmyheadandbody left a comment

mokimo commented Mar 13, 2024 •

edited

Loading

overmyheadandbody left a comment

overmyheadandbody Mar 14, 2024

SilviuLCF left a comment

narcis-radu left a comment

narcis-radu Mar 18, 2024

narcis-radu Mar 18, 2024

[MWPW-137148] [PERFORMANCE] Load IMS from the same domain #1996

[MWPW-137148] [PERFORMANCE] Load IMS from the same domain #1996

Conversation

mokimo commented Mar 12, 2024 • edited Loading

Description

Related Issue

Testing instructions

Runnings this action locally

Test URLs

codecov bot commented Mar 12, 2024 • edited Loading

Codecov Report

aem-code-sync bot commented Mar 12, 2024 • edited Loading

JasonHowellSlavin left a comment

Choose a reason for hiding this comment

overmyheadandbody left a comment

Choose a reason for hiding this comment

mokimo commented Mar 13, 2024 • edited Loading

overmyheadandbody left a comment

Choose a reason for hiding this comment

overmyheadandbody Mar 14, 2024

Choose a reason for hiding this comment

SilviuLCF left a comment

Choose a reason for hiding this comment

narcis-radu left a comment

Choose a reason for hiding this comment

narcis-radu Mar 18, 2024

Choose a reason for hiding this comment

narcis-radu Mar 18, 2024

Choose a reason for hiding this comment

mokimo commented Mar 12, 2024 •

edited

Loading

codecov bot commented Mar 12, 2024 •

edited

Loading

aem-code-sync bot commented Mar 12, 2024 •

edited

Loading

mokimo commented Mar 13, 2024 •

edited

Loading