MWPW-146755: RTL merch icon padding #2162

Axelcureno · 2024-04-18T16:15:39Z

Fixes RTL padding on merch card icons.

Reported URL:
Before: https://main--cc--adobecom.hlx.page/eg_ar/products/illustrator/text-to-vector-graphic
After: https://main--cc--adobecom.hlx.page/eg_ar/products/illustrator/text-to-vector-graphic?milolibs=MWPW-146755--milo--adobecom

Test URLs:

aem-code-sync · 2024-04-18T16:15:42Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

4b90198 ✅ (latest)
4e5e9e7 ✅
45dfd8d ✅
9b38c11 ✅
dec9138 ✅

aem-code-sync · 2024-04-18T16:16:22Z

Page	Scores	Audits	Google
/docs/library/kitchen-sink/merch-card?martech=off

codecov · 2024-04-18T16:18:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (8c8834f) to head (4b90198).

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2162      +/-   ##
==========================================
- Coverage   96.66%   96.65%   -0.01%     
==========================================
  Files         165      165              
  Lines       43550    43550              
==========================================
- Hits        42096    42095       -1     
- Misses       1454     1455       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

overmyheadandbody

Cards seem to have proper spacing now

narcis-radu

Thank you, Axel!

github-actions · 2024-04-20T01:09:22Z

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

github-actions · 2024-04-25T01:12:17Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

drashti1712 · 2024-04-25T10:14:19Z

Hi @Axelcureno
The aem-psi-check is failing for this PR. Could you please look into it?

Axelcureno · 2024-04-25T16:44:37Z

Hi @Axelcureno The aem-psi-check is failing for this PR. Could you please look into it?

@drashti1712 it's now passing. Thank you.

* Update code owners for feds (#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (#2208) * Update code owners for feds (#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (adobecom#2208) * Update code owners for feds (adobecom#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (adobecom#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (adobecom#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (adobecom#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* RTL padding merch icon * dep update

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (adobecom#2208) * Update code owners for feds (adobecom#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (adobecom#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (adobecom#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (adobecom#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

RTL padding merch icon

dec9138

Axelcureno requested review from yesil, narcis-radu, npeltier and 3ch023 April 18, 2024 16:15

Axelcureno self-assigned this Apr 18, 2024

Axelcureno added bug Something isn't working run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer merch card labels Apr 18, 2024

overmyheadandbody approved these changes Apr 19, 2024

View reviewed changes

yesil approved these changes Apr 19, 2024

View reviewed changes

narcis-radu approved these changes Apr 19, 2024

View reviewed changes

mokimo approved these changes Apr 24, 2024

View reviewed changes

Axelcureno added 2 commits April 24, 2024 08:50

Merge branch 'stage' into MWPW-146755

9b38c11

dep update

45dfd8d

aem-code-sync bot temporarily deployed to MWPW-146755 April 24, 2024 15:51 Inactive

Axelcureno requested review from afmicka and Roycethan April 24, 2024 15:54

Roycethan approved these changes Apr 24, 2024

View reviewed changes

Roycethan added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Apr 24, 2024

Merge branch 'stage' into MWPW-146755

4e5e9e7

aem-code-sync bot temporarily deployed to MWPW-146755 April 25, 2024 03:16 Inactive

Axelcureno added the Ready for Stage label Apr 25, 2024

Merge branch 'stage' into MWPW-146755

4b90198

aem-code-sync bot deployed to MWPW-146755 April 25, 2024 15:17 View deployment

Ruchika4 merged commit f847222 into stage Apr 25, 2024
12 checks passed

Ruchika4 deleted the MWPW-146755 branch April 25, 2024 17:32

Ruchika4 mentioned this pull request Apr 25, 2024

[Release] Stage to Main #2208

Merged

mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024

MWPW-146755: RTL merch icon padding (adobecom#2162)

63abf6f

* RTL padding merch icon * dep update

github-actions bot mentioned this pull request Apr 30, 2024

[Release] Stage to Main mokimo/milo#57

Closed

mokimo mentioned this pull request May 7, 2024

[Release] Stage to Main mokimo/milo#59

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-146755: RTL merch icon padding #2162

MWPW-146755: RTL merch icon padding #2162

Axelcureno commented Apr 18, 2024 •

edited

Loading

aem-code-sync bot commented Apr 18, 2024 •

edited

Loading

aem-code-sync bot commented Apr 18, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading

overmyheadandbody left a comment

narcis-radu left a comment

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 25, 2024

drashti1712 commented Apr 25, 2024

Axelcureno commented Apr 25, 2024

MWPW-146755: RTL merch icon padding #2162

MWPW-146755: RTL merch icon padding #2162

Conversation

Axelcureno commented Apr 18, 2024 • edited Loading

aem-code-sync bot commented Apr 18, 2024 • edited Loading

aem-code-sync bot commented Apr 18, 2024 • edited Loading

codecov bot commented Apr 18, 2024 • edited Loading

Codecov Report

overmyheadandbody left a comment

Choose a reason for hiding this comment

narcis-radu left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 25, 2024

drashti1712 commented Apr 25, 2024

Axelcureno commented Apr 25, 2024

Axelcureno commented Apr 18, 2024 •

edited

Loading

aem-code-sync bot commented Apr 18, 2024 •

edited

Loading

aem-code-sync bot commented Apr 18, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading