[Release] Stage to Main #2208

Ruchika4 · 2024-04-25T17:35:04Z

Update code owners for feds #2194 (Zero Impact)
Harden preflight link checking #2169 (trivial)
MWPW-146755: RTL merch icon padding #2162
MWPW-146001 parallelize literals call #2187 (trivial)

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* RTL padding merch icon * dep update

aem-code-sync · 2024-04-25T17:35:09Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

dac9c7e ✅ (latest)
f847222 ✅
8ee620d ✅
f18c399 ✅

codecov · 2024-04-25T17:37:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (1332031) to head (dac9c7e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
- Coverage   96.65%   96.65%   -0.01%     
==========================================
  Files         165      165              
  Lines       43525    43533       +8     
==========================================
+ Hits        42069    42076       +7     
- Misses       1456     1457       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-26T01:10:37Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

* MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (#2208) * Update code owners for feds (#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (adobecom#2208) * Update code owners for feds (adobecom#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (adobecom#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (adobecom#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (adobecom#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

narcis-radu and others added 3 commits April 25, 2024 10:31

Update code owners for feds (#2194)

f18c399

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

MWPW-146755: RTL merch icon padding (#2162)

f847222

* RTL padding merch icon * dep update

Ruchika4 added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs labels Apr 25, 2024

Ruchika4 requested review from narcis-radu, Blainegunn, overmyheadandbody, mokimo and a team April 25, 2024 17:35

JackySun9 approved these changes Apr 25, 2024

View reviewed changes

JackySun9 added the MIQ SOT👌 label Apr 25, 2024

tedAir approved these changes Apr 25, 2024

View reviewed changes

tedAir added the DC SOT 👌 label Apr 25, 2024

Roycethan approved these changes Apr 25, 2024

View reviewed changes

Roycethan added the Homepage SOT 👌 label Apr 25, 2024

rgclayton approved these changes Apr 25, 2024

View reviewed changes

MWPW-146001 parallelize literals call (#2187)

dac9c7e

* MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut

Ruchika4 requested a review from a team as a code owner April 26, 2024 14:07

aem-code-sync bot temporarily deployed to stage April 26, 2024 14:07 Inactive

vladen requested a review from Roycethan April 26, 2024 14:35

vladen approved these changes Apr 26, 2024

View reviewed changes

vladen removed the Homepage SOT 👌 label Apr 26, 2024

mokimo approved these changes Apr 26, 2024

View reviewed changes

Roycethan approved these changes Apr 27, 2024

View reviewed changes

overmyheadandbody approved these changes Apr 29, 2024

View reviewed changes

sigadamvenkata approved these changes Apr 29, 2024

View reviewed changes

sigadamvenkata added the CC SOT 👌 label Apr 29, 2024

aem-code-sync bot temporarily deployed to project-pep-prep April 29, 2024 11:06 Inactive

narcis-radu approved these changes Apr 29, 2024

View reviewed changes

Roycethan added the Homepage SOT 👌 label Apr 29, 2024

vhargrave merged commit 7f196f5 into main Apr 29, 2024
27 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #2208

[Release] Stage to Main #2208

Ruchika4 commented Apr 25, 2024 •

edited by vladen

Loading

aem-code-sync bot commented Apr 25, 2024 •

edited

Loading

codecov bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024

[Release] Stage to Main #2208

[Release] Stage to Main #2208

Conversation

Ruchika4 commented Apr 25, 2024 • edited by vladen Loading

aem-code-sync bot commented Apr 25, 2024 • edited Loading

codecov bot commented Apr 25, 2024 • edited Loading

Codecov Report

github-actions bot commented Apr 26, 2024

Ruchika4 commented Apr 25, 2024 •

edited by vladen

Loading

aem-code-sync bot commented Apr 25, 2024 •

edited

Loading

codecov bot commented Apr 25, 2024 •

edited

Loading