[MWPW-147001] Stage initiative automation (Stage-Main sync PRs) #2224
Conversation
|
.github/workflows/merge-to-stage.js
Outdated
| // Run from the root of the project for local testing: node --env-file=.env .github/workflows/merge-to-stage.js | ||
| const prTitle = '[Release] Stage to Main'; | ||
| const seen = {}; | ||
| const requiredApprovals = process.env.REQUIRED_APPROVALS || 2; |
There was a problem hiding this comment.
Does this take code owners into account? Say that a PR brings changes to the marquee and 2 reviewers approve, none of which are listed as code owners for the marquee. Should the approval "count" in that scenario?
There was a problem hiding this comment.
We don't require this at the moment either - 2 approvals & that counts. Code owners are just automatically looped in/requested for reviews
There was a problem hiding this comment.
true, but it's a good point from @overmyheadandbody , maybe in the future we will need this..
There was a problem hiding this comment.
Github offers this OOTB for a whole repo, we can still decide to enable this at some point
So far it hasn't been an issue and hope it won't be in the future either - but the option is there
There was a problem hiding this comment.
Hmm, maybe someone de-activated it recently? A couple of months ago at least one code owner had to review the PR, even though it had more than 2 approvals already. And I'd say it's fair enough, that's one of the reasons we have the codeowners in the first place - automatically assign the specialized person and have them give their two cents. This might deserve some further discussion to understand who and why disabled this rule.
|
This PR is currently in the |
add high prio PRs
Add a high impact slack webhook
mokimo
added
verified
Based on the discussion, the first workflow that will merge PRs into stage and open stage->main syncs.
PRs will be merged right after applying the
Ready for Stagelabel if possible, or in a 24h interval. Once we have the stage->main MERGE workflow, that will also trigger opening a new stage->main sync instantly.Resolves: MWPW-147001
Test URLs: