[Release] Stage to Main #2270
[Release] Stage to Main #2270
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* [MWPW-147001] Stage initiative automation * Add high prio PRs & fail on RCP cutoff * Rename constants * Add exclamation mark * Add the alert emoji * Add a high impact slack webhook * Re-add overlap check --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… the gnav file (#2252) * Merging inline-block to milo branch for further updates (#2170) * MWPW-135821 introduce custom action - and inaugurating first custom action for replacing cards in collection * MWPW-135821 use prefix in selector * MWPW-135821 adding preview data --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> * initial commit with TODO * registerCustomAction updated * fragment, highlight fragment and merch-card update * chain fragment support added * inBlock fragments with URL and path as keys * css selectors starting to work * Add forceInline to handleCommands * stash * unit tests mostly done * fix mocking issue * add martech-metadata to unit test mock and check for replace * change name of registerCustomAction to registerInBlockActions * indent issue * remove mep useBlockCode Example * merch-card-collection-fix * update merch-card-collection unit test * ignore lines that cannot be reached by unit tests * rename CUSTOM_SELECTOR_PREFIX * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * call addHash once, not twice * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
* MWPW-144549 CTA alignment for Text, Icon, and Media Blocks * fix text block icon-inline
…#2216) refactor(video-metadata): createVideoObject(record)
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
github-actions
bot
requested review from
hparra,
ryanmparrish,
a team,
elan-tbx,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
…bove icons (#2240) * Check for block content and use as header if exists, updated twitter icon ref * Refactored to allow for authoring icon discression * share.test for new custom title, refactored so .inline doesn't have title support * remove test console * linting * eslint adjust better readability * addressed issue found when block has no content row
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
+ Coverage 95.64% 95.69% +0.04%
==========================================
Files 166 166
Lines 43871 44009 +138
==========================================
+ Hits 41961 42115 +154
+ Misses 1910 1894 -16 ☔ View full report in Codecov by Sentry. |
* add rule for action area immediately following a heading * add quotes to selector to bring it into alignment with other styles
|
@ryanmparrish For #2240 , it looks like the default Share block used to say "Share this page" but now there's no copy by default. Is that expected behavior? Main: https://main--bacom--adobecom.hlx.page/drafts/denli/blocks/share Stage: https://main--bacom--adobecom.hlx.page/drafts/denli/blocks/share?milolibs=stage |
The bacom authors aren't aware of any Share blocks live on the site, so this isn't a blocking issue for us. Everything else looks good. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Stage automation PRs:
The sub-PRs got fast tracked & admin merged as they are all zero impact and need to be tested on a fully-fledged environment for permission reasons.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: