MWPW-142590 - [Share] enhancement (resubmit) - ability to edit text above icons

[ryanmparrish]

Resubmitting this PR

This was previously reverted due to an issue found on a live page. This was caused when a share block is authored w/ out a content row. See LIVE CC example below. (no authoring changes required)

---

Authors would like to modify the 'Share this page' text that appears above the social icons in the Share block.

Enabled author-able share titles
Updated the twitter logo use new X version

Note: The variant .inline does not support a title and strips out any authored text in the block content.

Resolves: MWPW-142590

Test URLs:

LIVE CC page: https://main--cc--adobecom.hlx.page/creativecloud/animation/discover/principles-of-animation?milolibs=rparrish-share-update

Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/share?martech=off
After: https://rparrish-share-update--milo--adobecom.hlx.page/drafts/rparrish/share?martech=off
Authoring Docs

Before: https://main--milo--adobecom.hlx.page/docs/authoring/examples/share-block?martech=off
After: https://rparrish-share-update--milo--adobecom.hlx.page/docs/authoring/examples/share-block?martech=off

Testing notes: To author a custom title in the Share block, simply add the title in the blocks first content row. Works with or without the custom share url authoring options.

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• ffe6025 ✅ (latest)
• 3881998 ✅
• afc010b ✅
• e865882 ✅
• 9216330 ✅
• 0a3a321 ✅
• 6352cb7 ✅
• c4ec916 ✅

[aem-code-sync]

Page	Scores	Audits	Google
/docs/authoring/examples/share-block?martech=off
/drafts/rparrish/share?martech=off

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 96.17%. Comparing base (88a24e8) to head (ffe6025).
Report is 42 commits behind head on stage.

Files	Patch %	Lines
libs/blocks/share/share.js	92.85%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2240      +/-   ##
==========================================
- Coverage   96.66%   96.17%   -0.49%     
==========================================
  Files         165      165              
  Lines       43525    43615      +90     
==========================================
- Hits        42072    41948     -124     
- Misses       1453     1667     +214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[SilviuLCF]

Verified : testing details
https://jira.corp.adobe.com/browse/MWPW-142590

Not adding label ready for stage yet since
@ryanmparrish there are still two checks on the PR that are not passing

CC @narcis-radu

[mokimo]

Approving and merging to stage as this was already on prod #2070 and the issues have been fixed and verified