Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-137282 - [Action Items] Centered in the grid/scroller #2237

Merged
merged 2 commits into from
May 10, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Apr 30, 2024

This PR addresses the issues found in #1501 with the masonry grid without all the extra files added to the diff in the old PR (why a new PR).

The spacing and width of action items nested within the scroller and section grid are not currently correct for the action-icons 3-5 up design examples. This is due to the way the grid template items are styled in both places. So we are adding functionality to make the action icons design layouts possible.

Resolves: MWPW-137282

Test URLs:

Action Items

Icon Blocks

Homepage Masonry (comparing to issue found in previous PR)

@Sartxi Sartxi added high-impact Any PR that may affect consumers new-feature New block or other feature needs-verification PR requires E2E testing by a reviewer labels Apr 30, 2024
Copy link
Contributor

aem-code-sync bot commented Apr 30, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (5dc834c) to head (e82181b).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2237      +/-   ##
==========================================
- Coverage   95.71%   95.70%   -0.02%     
==========================================
  Files         166      166              
  Lines       44007    43996      -11     
==========================================
- Hits        42122    42106      -16     
- Misses       1885     1890       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Apr 30, 2024

Copy link
Contributor

github-actions bot commented May 1, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@rgclayton rgclayton added the verified PR has been E2E tested by a reviewer label May 7, 2024
@SilviuLCF SilviuLCF added verified PR has been E2E tested by a reviewer Ready for Stage and removed verified PR has been E2E tested by a reviewer needs-verification PR requires E2E testing by a reviewer labels May 8, 2024
@SilviuLCF SilviuLCF self-requested a review May 8, 2024 08:32
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milo-pr-merge milo-pr-merge bot merged commit a9a453c into stage May 10, 2024
12 checks passed
@milo-pr-merge milo-pr-merge bot deleted the sartxi/MWPW-137282-action-centering branch May 10, 2024 04:10
@milo-pr-merge milo-pr-merge bot mentioned this pull request May 10, 2024
raga-adbe-gh added a commit that referenced this pull request May 10, 2024
raga-adbe-gh added a commit that referenced this pull request May 10, 2024
…2286)

Revert "MWPW-137282 - [Action Items] Centered in the grid/scroller (#2237)"

This reverts commit a9a453c.
@mokimo
Copy link
Contributor

mokimo commented May 10, 2024

@Sartxi seems like there have been some issues and this was pulled out of the branch.
Make sure to get some sign-off from @spadmasa when you open this for another round before it going to stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-impact Any PR that may affect consumers new-feature New block or other feature Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants