-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-137282 - [Action Items] Centered in the grid/scroller #2237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2237 +/- ##
==========================================
- Coverage 95.71% 95.70% -0.02%
==========================================
Files 166 166
Lines 44007 43996 -11
==========================================
- Hits 42122 42106 -16
- Misses 1885 1890 +5 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified : testing details
https://jira.corp.adobe.com/browse/MWPW-137282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified , testing details
This PR addresses the issues found in #1501 with the masonry grid without all the extra files added to the diff in the old PR (why a new PR).
The spacing and width of action items nested within the scroller and section grid are not currently correct for the
action-icons
3-5 up design examples. This is due to the way the grid template items are styled in both places. So we are adding functionality to make the action icons design layouts possible.Resolves: MWPW-137282
Test URLs:
Action Items
Icon Blocks
Homepage Masonry (comparing to issue found in previous PR)