Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2284

Merged
merged 4 commits into from
May 14, 2024
Merged

[Release] Stage to Main #2284

merged 4 commits into from
May 14, 2024

Conversation

sharmrj and others added 3 commits May 10, 2024 00:39
…ew is not working as expected ,navigation menu when opened is not seen rendered completely in MILO Pages (#2185)

* Fixed content being cutoff when menu is open in mobile/tablet viewports

* Undid prior css change and fixed an issue whoch caused setHamburgerMenu to never be called
)

* highlight of single column table is now visible

* width of highlight changed to fit row if it has a single child

---------

Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com>
Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com>
functionality to justify center items within a grid

Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Copy link
Contributor

aem-code-sync bot commented May 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented May 10, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (95ab427) to head (584f6da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   95.69%   95.70%   +0.01%     
==========================================
  Files         166      166              
  Lines       44009    44009              
==========================================
+ Hits        42115    42121       +6     
+ Misses       1894     1888       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…2286)

Revert "MWPW-137282 - [Action Items] Centered in the grid/scroller (#2237)"

This reverts commit a9a453c.
@mokimo mokimo temporarily deployed to milo_pr_merge May 10, 2024 12:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 10, 2024 16:10 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 10, 2024 20:08 — with GitHub Actions Inactive
@meganthecoder meganthecoder requested a review from a team May 10, 2024 21:05
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@mokimo mokimo temporarily deployed to milo_pr_merge May 11, 2024 04:09 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 11, 2024 08:10 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 11, 2024 12:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 11, 2024 16:09 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 11, 2024 20:08 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 12, 2024 00:42 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 12, 2024 04:10 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 12, 2024 08:10 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 12, 2024 12:15 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 12, 2024 16:09 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 12, 2024 20:08 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 13, 2024 00:40 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 13, 2024 04:11 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 13, 2024 08:12 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 13, 2024 12:15 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 13, 2024 16:11 — with GitHub Actions Inactive
@tedAir tedAir self-requested a review May 13, 2024 17:01
@mokimo mokimo temporarily deployed to milo_pr_merge May 13, 2024 20:08 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 14, 2024 00:39 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge May 14, 2024 04:09 — with GitHub Actions Inactive
@mokimo mokimo merged commit d949be5 into main May 14, 2024
54 of 61 checks passed
@mokimo mokimo temporarily deployed to milo_pr_merge May 14, 2024 05:59 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.