MWPW-151392: Sorting button/menu issues on Mobile

[mirafedas]

Changed the SWC version to 0.45.0, which includes the fix for the action menu component.

Resolves: MWPW-151392

Test URLs:

• Before: https://main-- cc--adobecom.hlx.live/products/catalog/?martech=off&mep=off
• After: https://main-- cc--adobecom.hlx.page/products/catalog?milolibs=mwpw-151392-swc-version--milo--mirafedas&martech=off&mep=off
  https://mwpw-151392-swc-version--milo--mirafedas.hlx.page/ - this is for passing the PSI check. As we don't have sidenav block in Milo, only in CC, it's impossible to create a test content page at the moment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (2abe70f) to head (f4fe7e0).
Report is 5 commits behind head on stage.

Additional details and impacted files

@@           Coverage Diff           @@
##            stage    #2690   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         173      173           
  Lines       45831    45834    +3     
=======================================
+ Hits        43958    43961    +3     
  Misses       1873     1873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[aem-code-sync]

	Page	Scores	Audits	Google
M	/
D	/

[Roycethan]

@mirafedas
I see the solution working for ios v 17 and higher ...but Sort button is not at all functional in ios v16 and lower
Reproducible in iPhone 14 v16.5 and iPhone 13 v15.2 and iPad 10th v16.0 and Mac Monterey Safari 15.2
video attached:

screenRecording-6-8-2024-12-47.mp4

[Roycethan]

@mirafedas Verified and covered regression. One glitch i see hlx.live Vs hlx.page in Safari browser. where clicking on sorting button works on hlx.page (https://main--cc--adobecom.hlx.page/products/catalog?milolibs=mwpw-151392-swc-version--milo--mirafedas ) and doesn't on hlx.live ( https://main--cc--adobecom.hlx.live/products/catalog?milolibs=mwpw-151392-swc-version--milo--mirafedas ) (attached Mac Sonoma Safari browserstack video) - Not sure what could be the reason but before adding ready for stage , plz check and if you could resolve it then you can add the label on my behalf.

screenRecording-13-8-2024-17-55.mp4

[github-actions]

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

[mirafedas]

@Roycethan I added a fix for the .live in Safari, could you please double-check if everything works after this?

[yesil]

can you try await import instead of loadScript in merch.js?
Also, contrary to what I said in slack, I think we should await polyfills() in catalog before loading any swc code to make sure that custom-elements are loaded.

[mirafedas]

@yesil when I replace the loadScript with a dynamic import, it doesn't work. What is the reason why we want to replace it?

[yesil]

@mirafedas awaiting the loadScript doesn't seem to block.
I would like to load custom-elements before any other SWC dependency.
Just trying to be on the safe side.

[Roycethan]

@Roycethan could you please verify once more?

@mirafedas Works now on Safari

[milo-pr-merge]

Skipped 2690: "MWPW-151392: Sorting button/menu issues on Mobile" due to file "libs/deps/mas/merch-card-all.js" overlap. Merging will be attempted in the next batch

[milo-pr-merge]

Skipped 2690: "MWPW-151392: Sorting button/menu issues on Mobile" due to file ".github/codeql/codeql-config.yml" overlap. Merging will be attempted in the next batch

[milo-pr-merge]

Skipped 2690: "MWPW-151392: Sorting button/menu issues on Mobile" due to file "libs/deps/mas/merch-card-all.js" overlap. Merging will be attempted in the next batch

[milo-pr-merge]

Skipped merging 2690: MWPW-151392: Sorting button/menu issues on Mobile due to failing checks