Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-151392: Sorting button/menu issues on Mobile #2690

Merged
merged 13 commits into from
Aug 21, 2024
Merged

MWPW-151392: Sorting button/menu issues on Mobile #2690

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a9a7f5f
changed the swc version to 0.46.0
mirafedas Aug 15, 2024
16cd14e
added polyfills import
mirafedas Aug 15, 2024
8ea5a7d
corrected import
mirafedas Aug 15, 2024
fd17f45
corrected import
mirafedas Aug 15, 2024
f3f0c30
added warning about polyfills in readme
mirafedas Aug 15, 2024
22121b9
fixed typos and changed imports
mirafedas Aug 15, 2024
c8418f6
corrected import
mirafedas Aug 15, 2024
322e3fd
brought back the loadScript
mirafedas Aug 15, 2024
488b37a
Merge branch 'stage' into mwpw-151392-swc-version
mirafedas Aug 16, 2024
493f875
correction for the readme
mirafedas Aug 16, 2024
85d0bc9
Merge branch 'stage' into mwpw-151392-swc-version
mirafedas Aug 19, 2024
e3c55c6
Merge branch 'stage' into mwpw-151392-swc-version
mirafedas Aug 19, 2024
f4fe7e0
Merge branch 'stage' into mwpw-151392-swc-version
mirafedas Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/features/spectrum-web-components/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ This repository provides individual Spectrum Web Components for consumption in S
This feature is mainly designed for consumption by the different merch blocks.

Please know that SWC is heavy, impacts page performance and is not suitable for cases where a Consonant component is already available in Milo, e.g: button.
Be aware that the polyfills from the `custom-element.js` must be loaded before SWC dependencies, otherwise if may cause issues (specifically in Safari).
mirafedas marked this conversation as resolved.
Show resolved Hide resolved

To load SWC components, do as follows:

Expand All @@ -13,7 +14,7 @@ await Promise.all([
import(`${base}/features/spectrum-web-components/dist/theme.js`),
import(`${base}/features/spectrum-web-components/dist/button.js`),
import(`${base}/features/spectrum-web-components/dist/search.js`),
]);
]);custom
mirafedas marked this conversation as resolved.
Show resolved Hide resolved
```
On the page embedd your SWCs in `sp-theme` component and append to the DOM

Expand Down
Loading