MWPW-157783 [MEP] Primary and Secondary CTA simplified selectors do not work well with hero-marquee block #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2830 +/- ##
==========================================
+ Coverage 95.89% 96.08% +0.19%
==========================================
Files 173 215 +42
Lines 46316 53945 +7629
==========================================
+ Hits 44415 51834 +7419
- Misses 1901 2111 +210 ☔ View full report in Codecov by Sentry. |
denlight
approved these changes
Sep 5, 2024
markpadbe
approved these changes
Sep 5, 2024
…ors (#2832) * mepanymarquee * add header * fix unit test
elan-tbx
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ot work well with hero-marquee block (#2830) * Make action-area more flexible * unit test update * also update other new css selectors * get rid of parent in selector * unit test update * MWPW-157785 [MEP] Create "any-marquee" and "header" simplified selectors (#2832) * mepanymarquee * add header * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new primary-cta and secondary-cta MEP simplified selectors do not work on hero-marquees because there is no paragraph around the buttons
Update CSS selector to also be able to catch divs
Resolves: MWPW-157783
QA instructions: We want the selectors to start working in hero-marquees but continue to work in regular marquees. To make it more obvious the content is updated, I changed the buttons to use the word new.
Test URLs:
Hero Marquee:
Before: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepactionarea/marquee?martech=off&mep=%2Fdrafts%2Fmepdev%2Ffragments%2F2024%2Fq4%2Fmepactionarea%2Fmarquee.json--primary+and+secondary
After: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepactionarea/marquee?martech=off&mep=%2Fdrafts%2Fmepdev%2Ffragments%2F2024%2Fq4%2Fmepactionarea%2Fmarquee.json--primary+and+secondary&milolibs=mepactionarea
Marquee:
Before: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepactionarea/max-lr-hero-option?martech=off&mep=%2Fdrafts%2Fmepdev%2Ffragments%2F2024%2Fq4%2Fmepactionarea%2Fmax-lr-hero-option.json--primary+and+secondary
After: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepactionarea/max-lr-hero-option?milolibs=mepactionarea&martech=off&mep=%2Fdrafts%2Fmepdev%2Ffragments%2F2024%2Fq4%2Fmepactionarea%2Fmax-lr-hero-option.json--primary+and+secondary
Psi-check: https://mepactionarea--milo--adobecom.hlx.page/?martech=off
Also includes this approved PR: #2832