MWPW-157785 [MEP] Create "any-marquee" and "header" simplified selectors #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepactionarea #2832 +/- ##
==============================================
Coverage 95.89% 95.89%
==============================================
Files 173 173
Lines 46316 46319 +3
==============================================
+ Hits 44414 44418 +4
+ Misses 1902 1901 -1 ☔ View full report in Codecov by Sentry. |
markpadbe
approved these changes
Sep 5, 2024
denlight
approved these changes
Sep 5, 2024
chrischrischris
approved these changes
Sep 5, 2024
vgoodric
changed the title
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ot work well with hero-marquee block (#2830) * Make action-area more flexible * unit test update * also update other new css selectors * get rid of parent in selector * unit test update * MWPW-157785 [MEP] Create "any-marquee" and "header" simplified selectors (#2832) * mepanymarquee * add header * fix unit test
elan-tbx
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ot work well with hero-marquee block (#2830) * Make action-area more flexible * unit test update * also update other new css selectors * get rid of parent in selector * unit test update * MWPW-157785 [MEP] Create "any-marquee" and "header" simplified selectors (#2832) * mepanymarquee * add header * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's becoming very common to switch between using the marquee block, interactive-marquee block or the hero-marquee block.
There's an easy CSS selector to get any of these, but if it was a simplified selector it would be easier to use.
Similarly, it can be hard to know which header level to use (h1, h2, h3 etc.) because they can look the same and even get changed by the decoration process. Although it can be achieved in CSS, it would be easier to have a simplified selector.
Resolves: MWPW-157785
Note the examples below use the same manifest with the same selector: "any-marquee primary-cta"
Test URLs:
Marquee:
Hero Marquee:
Interactive Marquee:
Before: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepanymarquee/interactive-marquee?martech=off
After: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepanymarquee/interactive-marquee?milolibs=mepanymarquee&martech=off
Psi-check: https://mepanymarquee--milo--adobecom.hlx.page/?martech=off