MWPW-158462 [MEP] any-marquee-section simplified selector #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2884 +/- ##
==========================================
+ Coverage 96.23% 96.24% +0.01%
==========================================
Files 237 237
Lines 54242 54240 -2
==========================================
+ Hits 52198 52202 +4
+ Misses 2044 2038 -6 ☔ View full report in Codecov by Sentry. |
Ruchika4
approved these changes
Sep 16, 2024
ivanvatadobe
approved these changes
Sep 16, 2024
… should not be (#2886) * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be * unit test repair * unit test repair
… into mepanymarqueesection
…but not in Target (#2887) * working so far * lint update * update something merging stage did not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received a request for a common use case: the section holding a marquee of any type.
Name of the new selector: any-marquee-section
Resolves: MWPW-158462
Test URLs:
Also contains #2886 and #2887 for conflict resolution