CCD Merch Card Combined changes

[Axelcureno]

This PR is a combination of the changes from #2927, #2995 and #3054 to ease the merging backlog caused by the RCP.

Resolves: MWPW-160518, MWPW-158200 and MWPW-158473

CCD Gallery: https://ccd-axel-changes--milo--adobecom.hlx.page/libs/features/mas/docs/ccd.html?theme=dark

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/libs/features/mas/docs/ccd.html?martech=off
• After: https://ccd-axel-changes--milo--adobecom.hlx.page/libs/features/mas/docs/ccd.html?martech=off

[afmicka]

@Axelcureno @Roycethan in figma, the See terms link is said specifically to be blue. The color is changed to grey in this commit and is left blue for all the other cards. Is there any file/place where this change is documented (need the latest requirements for the automation tests)? cc: @3ch023

In the dev file all the cards are with blue See terms in the screenshots and with text requirements for legal links to be grey (though i believe they meant grey for the line below the links, where prices are).

This either needs to be changed for all the cards or left blue for all the cards. Changing it only for suggested cards seems off to me.

[milo-pr-merge]

Skipped 3063: "CCD Merch Card Combined changes" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch

[afmicka]

@Axelcureno also, strikethrough price is lighter grey in the card design in figma files. Not sure it that is something that needs to be accommodated as well

[3ch023]

@afmicka would it be ok if we address it in the next PR? this one is blocking another upcoming change that we need soon

[Axelcureno]

@Axelcureno also, strikethrough price is lighter grey in the card design in figma files. Not sure it that is something that needs to be accommodated as well

@afmicka from what browser are you seeing this? It looks as expected in Chrome:

[afmicka]

@3ch023 @Axelcureno
For me the prices are not rendering on CCD page for suggested cards in Safari after the latest changes. Could you please take a look? Removing the label until this is comfirmed.

[afmicka]

@Axelcureno also, strikethrough price is lighter grey in the card design in figma files. Not sure it that is something that needs to be accommodated as well

@afmicka from what browser are you seeing this? It looks as expected in Chrome:

@Axelcureno I look the design at figma files in chrome browser. In figma is light colour, in real browser is dark one

1. https://www.figma.com/design/7tUtNgFelfMjgPoJ5QcE1k/Merch%40Scale-Frameworks?node-id=2034-44369&node-type=frame&t=5QtthpCU9hdUai35-0

2. https://www.figma.com/proto/7tUtNgFelfMjgPoJ5QcE1k/Merch%40Scale-Frameworks?node-id=2034-44369&t=8hahWyGISCJhs7SZ-1&show-proto-sidebar=1&starting-point-node-id=2034%3A44311

[Axelcureno]

@3ch023 @Axelcureno For me the prices are not rendering on CCD page for suggested cards after the latest changes. Could you please take a look? Removing the label until this is comfirmed.

@afmicka prices render fine for me. Can you share more details of browser and URL? Are you connected to VPN? Please keep in mind only Chrome browser is in scope for this project. I see fonts are also not rendering in your page, that should not be happening.

[afmicka]

@3ch023 @Axelcureno For me the prices are not rendering on CCD page for suggested cards after the latest changes. Could you please take a look? Removing the label until this is comfirmed.

@afmicka prices render fine for me. Can you share more details of browser and URL? Are you connected to VPN? Please keep in mind only Chrome browser is in scope for this project. I see fonts are also not rendering in your page, that should not be happening.

Sorry, did not finish the message properly before hitting enter.
Safari browser (connected to VPN): https://ccd-axel-changes--milo--adobecom.hlx.page/libs/features/mas/docs/ccd.html

[afmicka]

Ok, putting back the label.

1. Strikethrough price color fixed
2. Safari is not in scope
3. See terms label color to be addressed in the next PR after clarifying the design for each card type
4. Fonts are part of other PR not yet merged

[github-actions]

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

[Roycethan]

@Axelcureno Looks like you changed the color for Strikethrough to "Blue" - can you plz check ? Also code coverage ?