[Release] Stage to Main #3102

milo-pr-merge · 2024-10-29T08:01:17Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

…blocks (#3091) * add a11y test for remaining blocks * fix eslint errors * comment MPC video for a11y test --------- Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@santoshumarsmbp.corp.adobe.com>

* MWPW-152228: refactor georouting promises call * refactor long line

* initial commit * slots, styles and basic layout * more changes * Update merch-card.ccd-suggested.test.html * Update merch-twp-d2p.test.html * unit tests, strip slot and more * fixed review comments * review comments fixed * RTL background image support * Initial @adobecom/mas-js version. * a * Update merch-card.ccd-suggested.test.html * a * dark mode, unit tests and rtl * simplified styles * updated deps * Update variant-layout.js * dark theme ut * Update merch-card.ccd-suggested.test.html.js * Update variant-layout.js * card mapping * MWPW-158200: Merch card Dark mode * updated deps * MWPW-159257 refactor mas enablement - move of wcms-commerce -> mas-commerce-service - move of some public functions to mas-commerce-service, - remove mas.js code for initialization, everything needs to go through the component, - split of settings code with locale settings, make milo locale settings an explicit function, - unit tests, - updates of docs, especially mas.js.html with that component * MWPW-159257 fix unit test + register co * review comments fixed * MWPW-159257 some feedbacks, more coverage * draft * bump pkg version * MWPW-160085: WIP * wip * fix cta mapping for suggested card * ccd-suggested fixes * dark theme update * remove css var * fix size attribute in hydrate * MWPW-159257 remove init & reset concept - also removed typescript stuff, - refactor mixin to simple aggregated MasElement, - refactor how things are initialised" * update docs * merge changes, add more docs * update docs * update docs * fix docu * add ccd test page * MWPW-159257 remove init & reset concept - also removed typescript stuff, - refactor mixin to simple aggregated MasElement, - refactor how things are initialised, - make merch block working with this * update docs * merge changes, add more docs * update ccd gallery * update docs * fix docu * add dark theme * merge * re-enable notification test * ost * add doc * fix fragment test init * add vpn banner * various fixes * MWPW-159257 move to relative path * MWPW-159257 various fixes * rename promise -> readyPromise not documenting it as i'm not sure it's needed by consumers * MWPW-160015: M@S: support for mnemonic multifield during card hydration. * MWPW-160511: add badge * MWPW-159257 enhance coverage * MWPW-159257 yet more coverage * MWPW-159257 final? * MWPW-159257 non reported cov issues * prob. some issue in cov reporting as its used several times * MWPW-159257 review fixes * yet some over c8 ignore * MWPW-159257 removing it.only & built docs * MWPW-159257 unwrap single condition block * fixed issued by by QA * MWPW-159257: [M@S] Support override env/landscape Milo only consumes WCS prod. However with this PR, on local and stage environments, `allow-override` parameter will be added to `mas-commerce-service` allowing to override the commerce env/landscape via query parameters. * PR feedback * reduce codecov requirement * CCD Merch Card Combined changes * updated deps * links in gray * updated deps * strip changes * updated deps * updated deps * attribute name fixed * updated deps and new logic in hydrate * updated deps * updated deps * padding for wide strip * wide stip condition * Update ccd.html * updated deps * suggested ccd card in test page * ut * add change in merch-card * strikethrough color * correct link colors * link colors * gray 800 link slice card --------- Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* Place app store buttons next to eachother * Add Robert's PR feedback * Address Rares PR feedback * Add aria-labels * Keep lines under 100 characters * Remove the margin of the container

milo-pr-merge · 2024-10-29T08:01:18Z

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

aem-code-sync · 2024-10-29T08:01:22Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

34e21ad ✅ (latest)
fded71e ✅
5f07d64 ✅
12dbfff ✅
1d36e98 ✅
351c302 ✅
dfff83f ✅
b916167 ✅
9fab9ff ✅

aem-code-sync · 2024-10-29T08:01:42Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/src/merch-icon.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/src/variants/ccd-slice.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/src/variants/ccd-suggested.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/src/variants/variant-layout.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/test/aem-fragment.test.html.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/test/merch-card.ccd-slice.test.html.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/mas/web-components/test/merch-card.ccd-suggested.test.html.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/spectrum-web-components/src/themes/dark.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/1d36e98d9d4abbd888b4ff28dd4450f9bc20ccb8/libs/features/spectrum-web-components/src/themes/light.js

github-actions · 2024-10-29T08:02:00Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@Axelcureno @3ch023 @npeltier @yesil could one of you look into ignoring some of the MAS files that get flagged by the linter consistently? It spams the PRs quite a lot and doesn't provide any value if we can't fix it to begin with

github-actions · 2024-10-29T08:02:01Z

libs/deps/mas/merch-card-collection.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:02Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:03Z

libs/deps/mas/merch-icon.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:04Z

libs/deps/mas/merch-sidenav.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:05Z

libs/deps/mas/merch-subscription-panel.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:05Z

libs/features/mas/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:06Z

libs/features/mas/web-components/src/global.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:07Z

libs/features/mas/web-components/src/hydrate.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:02:08Z

libs/features/mas/web-components/src/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-10-29T08:03:03Z

Codecov Report

Attention: Patch coverage is 85.22073% with 77 lines in your changes missing coverage. Please review.

Project coverage is 96.33%. Comparing base (ff054af) to head (34e21ad).
Report is 77 commits behind head on main.

Files with missing lines	Patch %	Lines
libs/blocks/preflight/panels/performance.js	78.86%	56 Missing ⚠️
libs/utils/samplerum.js	68.65%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3102      +/-   ##
==========================================
- Coverage   96.45%   96.33%   -0.12%     
==========================================
  Files         246      247       +1     
  Lines       55909    56235     +326     
==========================================
+ Hits        53925    54176     +251     
- Misses       1984     2059      +75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Make IMS timeout configurable

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/12dbfffff6dcd3981df410c19893bf091b9530e8/libs/features/spectrum-web-components/src/themes/light.js

github-actions · 2024-10-29T08:15:21Z

libs/features/mas/web-components/src/merch-icon.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:15:22Z

libs/features/mas/web-components/src/variants/ccd-slice.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:15:23Z

libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T08:15:24Z

libs/features/mas/web-components/src/variants/ccd-suggested.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-29T12:09:26Z

libs/features/spectrum-web-components/src/themes/light.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

* Added performance tab to the Preflight tool (#2773) added performance tab * Fixes upon testing * Address Rares PR Feedback * Address Narcis PR feedback * Address Roberts PR feedback --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

… feature (#3067) * relative urls support for same domain consumers * hotfix * added unit tests * added more complexity to the testing regexp * hotfix * implementing feedback

skumar09 and others added 5 commits October 29, 2024 08:00

[MWPW-161069][NALA][A11Y] Add accessibility automation test for Milo …

9fab9ff

…blocks (#3091) * add a11y test for remaining blocks * fix eslint errors * comment MPC video for a11y test --------- Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@santoshumarsmbp.corp.adobe.com>

MWPW-159791 Support Next-Gen Sidekick (#3025)

b916167

MWPW-152228: refactor georouting promises call (#3036)

dfff83f

* MWPW-152228: refactor georouting promises call * refactor long line

MWPW-160834: Clickable App and Playstore links (#3074)

1d36e98

* Place app store buttons next to eachother * Add Robert's PR feedback * Address Rares PR feedback * Add aria-labels * Keep lines under 100 characters * Remove the margin of the container

milo-pr-merge bot requested review from ryanmparrish and Sartxi as code owners October 29, 2024 08:01

github-actions bot reviewed Oct 29, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge October 29, 2024 08:14 — with GitHub Actions Inactive

MWPW-159605 Allow consumer apps set IMS timeout value (#3037)

12dbfff

Make IMS timeout configurable

aem-code-sync bot temporarily deployed to stage October 29, 2024 08:14 Inactive

github-actions bot reviewed Oct 29, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge October 29, 2024 12:20 — with GitHub Actions Inactive

[MWPW-159595] - support same domain consumers in the links conversion…

34e21ad

… feature (#3067) * relative urls support for same domain consumers * hotfix * added unit tests * added more complexity to the testing regexp * hotfix * implementing feedback

aem-code-sync bot temporarily deployed to stage October 29, 2024 12:20 Inactive

mokimo temporarily deployed to milo_pr_merge October 29, 2024 16:13 — with GitHub Actions Inactive

Roycethan approved these changes Oct 29, 2024

View reviewed changes

Roycethan added the Homepage SOT 👌 label Oct 29, 2024

Roycethan temporarily deployed to milo_pr_merge October 29, 2024 18:24 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 29, 2024 20:11 — with GitHub Actions Inactive

tedAir self-requested a review October 29, 2024 22:51

tedAir approved these changes Oct 29, 2024

View reviewed changes

tedAir added the DC SOT 👌 label Oct 29, 2024

tedAir temporarily deployed to milo_pr_merge October 29, 2024 22:52 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 30, 2024 00:51 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 30, 2024 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 30, 2024 08:14 — with GitHub Actions Inactive

sigadamvenkata requested a review from mokimo October 30, 2024 08:42

sigadamvenkata added the CC SOT 👌 label Oct 30, 2024

sigadamvenkata temporarily deployed to milo_pr_merge October 30, 2024 08:44 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 30, 2024 09:16 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 30, 2024 12:20 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge October 30, 2024 16:13 — with GitHub Actions Inactive

JackySun9 approved these changes Oct 30, 2024

View reviewed changes

JackySun9 added BAcom SOT 👌 MIQ SOT👌 labels Oct 30, 2024

JackySun9 temporarily deployed to milo_pr_merge October 30, 2024 17:34 — with GitHub Actions Inactive

milo-pr-merge bot merged commit 9d89ed8 into main Oct 30, 2024
48 of 50 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge October 30, 2024 17:35 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #3102

[Release] Stage to Main #3102

milo-pr-merge bot commented Oct 29, 2024 •

edited

Loading

milo-pr-merge bot commented Oct 29, 2024

aem-code-sync bot commented Oct 29, 2024 •

edited

Loading

aem-code-sync bot commented Oct 29, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Oct 29, 2024

mokimo Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

codecov bot commented Oct 29, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

github-actions bot Oct 29, 2024

[Release] Stage to Main #3102

[Release] Stage to Main #3102

Conversation

milo-pr-merge bot commented Oct 29, 2024 • edited Loading

common base root URLs

milo-pr-merge bot commented Oct 29, 2024

aem-code-sync bot commented Oct 29, 2024 • edited Loading

aem-code-sync bot commented Oct 29, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

mokimo Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot Oct 29, 2024

Choose a reason for hiding this comment

milo-pr-merge bot commented Oct 29, 2024 •

edited

Loading

aem-code-sync bot commented Oct 29, 2024 •

edited

Loading

aem-code-sync bot commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading