Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-160862] [Milo OST] Add 'Save now' to dropdown of CTA text options #3088

Merged
merged 9 commits into from
Oct 28, 2024
Merged

[MWPW-160862] [Milo OST] Add 'Save now' to dropdown of CTA text options #3088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd23cbb
Add "Save now" to the OST CTAs options
Oct 24, 2024
80b197e
review comment
Oct 24, 2024
4dc7f83
UT fix
Oct 24, 2024
a73f1e5
dummy commit
Oct 24, 2024
62a2949
Revert "dummy commit"
Oct 24, 2024
24c3d4b
dummy commit for intermittent test failure
Oct 24, 2024
9004b00
Revert "dummy commit for intermittent test failure"
Oct 24, 2024
8d2d7bc
dummy commit
Oct 24, 2024
4c3d897
Revert "dummy commit"
Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/blocks/ost/ctaTextOption.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const ctaTextOption = {
{ id: 'buy-now', name: 'Buy now' },
{ id: 'free-trial', name: 'Free trial' },
{ id: 'start-free-trial', name: 'Start free trial' },
{ id: 'save-now', name: 'Save now' },
{ id: 'get-started', name: 'Get started' },
{ id: 'choose-a-plan', name: 'Choose a plan' },
{ id: 'learn-more', name: 'Learn more' },
Expand Down
1 change: 1 addition & 0 deletions test/blocks/ost/textOption.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ describe('test ctaTextOption', () => {
const EXPECTED_TEXTS = [{ id: 'buy-now', name: 'Buy now' },
{ id: 'free-trial', name: 'Free trial' },
{ id: 'start-free-trial', name: 'Start free trial' },
{ id: 'save-now', name: 'Save now' },
{ id: 'get-started', name: 'Get started' },
{ id: 'choose-a-plan', name: 'Choose a plan' },
{ id: 'learn-more', name: 'Learn more' },
Expand Down
Loading