Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-160862] [Milo OST] Add 'Save now' to dropdown of CTA text options #3088

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

rohitsahu
Copy link
Contributor

@rohitsahu rohitsahu commented Oct 24, 2024

Add "Save now" to the OST CTAs options
Ignore the below urls for testing. Provide adobe.com token to test the functionality in OST.

Before:
Screenshot 2024-10-24 at 12 52 56 PM

After:
Screenshot 2024-10-24 at 2 30 31 PM

Resolves: MWPW-160862

Test URLs:

@rohitsahu rohitsahu requested a review from a team as a code owner October 24, 2024 07:30
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (543ef4d) to head (4c3d897).
Report is 12 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3088   +/-   ##
=======================================
  Coverage   96.43%   96.44%           
=======================================
  Files         245      245           
  Lines       55746    55747    +1     
=======================================
+ Hits        53757    53763    +6     
+ Misses       1989     1984    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Oct 24, 2024

Page Scores Audits Google
📱 /drafts/rosahu/innovatex/badgealign PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/rosahu/innovatex/badgealign PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@yesil
Copy link
Contributor

yesil commented Oct 24, 2024

@rohitsahu can you move it after "Start free trial" it will be easier to pick.

Rohit Sahu added 2 commits October 24, 2024 14:58
(cherry picked from commit a73f1e5)
This reverts commit 8d2d7bc.
@rohitsahu
Copy link
Contributor Author

Had to make few dummy commits to fix intermittent UT and psi failures (reverted ofcourse). Please ignore those commits

@3ch023 3ch023 added commerce run-nala Run Nala Test Automation against PR labels Oct 24, 2024
@rohitsahu rohitsahu added the needs-verification PR requires E2E testing by a reviewer label Oct 24, 2024
@yesil
Copy link
Contributor

yesil commented Oct 24, 2024

@afmicka @Roycethan this is a no impact one. can we add the label?

Copy link
Contributor

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

@rohitsahu
Copy link
Contributor Author

rohitsahu commented Oct 24, 2024

@afmicka @Roycethan this is a no impact one. can we add the label?

Added @yesil but got removed

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage high priority Why is this a high priority? Blocker? Critical? Dependency? and removed needs-verification PR requires E2E testing by a reviewer labels Oct 24, 2024
@milo-pr-merge milo-pr-merge bot merged commit 1f5db0e into adobecom:stage Oct 28, 2024
43 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants