[Release] Stage to Main #3093
Merged
[Release] Stage to Main #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
…ns (#3088) * Add "Save now" to the OST CTAs options * review comment * UT fix * dummy commit * Revert "dummy commit" This reverts commit a73f1e5. * dummy commit for intermittent test failure * Revert "dummy commit for intermittent test failure" This reverts commit 24c3d4b. * dummy commit (cherry picked from commit a73f1e5) * Revert "dummy commit" This reverts commit 8d2d7bc. --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com>
* Adding a dynamic nav status button into the global nav to aid content QA in understanding which nav is active * Code review comments: cleaned css and added prod check in loadDeferred to disable status. Updated tests * Moving styles into utils, as loading within module caused CLS * CSS typo * ESLint error * Change for clarity in utils * PR requested changes * Changes requested from QA
…#3018) * Fixed max width of heading and badge if badge is present for product cards * review comment * review comment * run build --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com>
* add .no-track to quiz cards * add .no-track to quiz-entry cards Resolves: [MWPW-152331](https://jira.corp.adobe.com/browse/MWPW-152331)
* MWPW-159555 Add support for lana-sample query param The `lana-sample` query param will override any sample rate defined elsewhere. Setting it to "100" will force lana to send everything to splunk. * Disable es-lint on lana.js * Use explicit eslint labels * Fix lana test to not intermittently fail * Add invalid value test
* fixed style for .empty-asset:empty to still take up dom space split w/ copy * set default lockup size for if no lockup variant gets authored * moved block lockup styled to main-copy and adjusted row-lockup to check icon and lockup suffix * large default * added support for breakpoint fill button styles * removed bg-tablet selectors in wrong media query * added extra `con-button.button-xxl` to support blocks w/ element level classes. * block button class target main-copy and removed so rows dont inherit * added .no-min-height * Test coverage for lockup size in row variant
Geo modal cls issue
* Graybox display specificity fix * ensure that the graybox block will never be seen, regardless of page content or setup Resolves: [MWPW-160469](https://jira.corp.adobe.com/browse/MWPW-160469) * remove odd unintended z-index changes * missed a ;
Adding tabindex to social share icons to make sure users can tab to them
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
colloyd,
fullcolorcoder,
JackySun9,
sabyamon,
a team,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3,
meganthecoder,
JasonHowellSlavin,
Brandon32 and
rgclayton
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
+ Coverage 96.43% 96.45% +0.01%
==========================================
Files 245 246 +1
Lines 55746 55909 +163
==========================================
+ Hits 53757 53925 +168
+ Misses 1989 1984 -5 ☔ View full report in Codecov by Sentry. |
tedAir
approved these changes
Oct 28, 2024
Roycethan
approved these changes
Oct 28, 2024
Roycethan
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
approved these changes
Oct 28, 2024
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
sigadamvenkata
approved these changes
Oct 29, 2024
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: