MWPW-154147: add spectrum switch component #3264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3264 +/- ##
=======================================
Coverage 96.37% 96.38%
=======================================
Files 245 245
Lines 56716 56733 +17
=======================================
+ Hits 54661 54680 +19
+ Misses 2055 2053 -2 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
@SonjaPopovic can you also add a simple unit test that verifies that it renders with a shadow dom?
SonjaPopovic
changed the title
SonjaPopovic
changed the title
|
Reminder to set the |
* MWPW-154147-spectrum switch * MWPW-154147-spectrum switch * MWPW-154147-spectrum switch test * MWPW-154147-spectrum switch test --------- Co-authored-by: Sonja Popovic <cod55010@adobe.com>
Resolves: MWPW-154147
Test URLs:
We would need to use sp-switch component on dme-partners, since it is needed to fully implement required UI on the ticket ( https://xd.adobe.com/view/04f48d4e-4285-4123-b732-228beca9eb47-51a7/ )
Added exports to checkbox.js for CheckboxBase.js', since switch.js imports it.
LINKS:
Before: https://MWPW-154147-pricelist--dme-partners--adobecom.hlx.page/channelpartners/drafts/sonja/pricelist
After: https://MWPW-154147-pricelist--dme-partners--adobecom.hlx.page/channelpartners/drafts/sonja/pricelist?milolibs=MWPW-154147-add-spectrum-switch-component--milo--SonjaPopovic
Before: https://main--milo--adobecom.aem.live/
After: https://MWPW-154147-add-spectrum-switch-component--milo--SonjaPopovic.aem.live/