[Release] Stage to Main #3331

milo-pr-merge · 2024-12-09T09:19:20Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

* Initial updates to handle new UX requirements * Add segment udpates * Fix class * Fix center text * rtl updates for segments * Remove rtl test * Add back padding * Fix padding and columns * Add fix for bad class * Remove comment * Update tests * Fix test * Update libs/blocks/timeline/timeline.js --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>

* Fix: Setting allowedOrigins for standalone gnav * Fix: Default handling

…idual SVG assets (#3259) * updated features/icons to pull from federal and allow the icons set to be sharepoint authorable * bettter icon-spacing handling * preload federated.js instead of non used icons.svg on util decorateIcon() * Updated preload federated as script type not fetch * Minor clean up based on pr feedback * remove console * addressed some issues found w/ icons not rending in tables due to race condition w/ decorateIcon() * lana instead of console * no 100% height * coverage * full coverage * minor cleanup * minor cleanup * preload first section icons, spread syntax * no cons * Performace refactor - loadIcons to hold most related functionallity. Preloaded inView icons and defered others till postSectionLoad. * async decTooltips and refactor to not chain func calls * fix: icon alignment in georouting modal's button * move render blocking code to utils * fix import of test method * remove condition that causes error when no icon is in view * remove redundant link load * remove extra federated.js import * small change to push branch * Fed Icons - Table icon decoration and collapse icon wrapping (#3202) * reselect icons after area is decorated * fix inline margin issue in table collapse titles --------- Co-authored-by: Saugat Malla <saugat@TBXTOR-2021MBP16-SaugatMalla.local> Co-authored-by: Saugat Malla <saugat013@gmail.com> Co-authored-by: Sartxi <sean.archibeque@gmail.com>

milo-pr-merge · 2024-12-09T09:19:21Z

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

aem-code-sync · 2024-12-09T09:19:26Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

39eafc8 ✅ (latest)
9884681 ✅
57d66cf ✅
7483f29 ✅
93b846c ✅
81a5770 ✅
e9f0bf2 ✅
02bf866 ✅

aem-code-sync · 2024-12-09T09:19:45Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

codecov · 2024-12-09T09:24:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (b72ed94) to head (39eafc8).
Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3331    +/-   ##
========================================
  Coverage   96.41%   96.42%            
========================================
  Files         246      246            
  Lines       57567    57676   +109     
========================================
+ Hits        55504    55613   +109     
  Misses       2063     2063

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-09T09:59:07Z

.github/workflows/helpers.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

github-actions · 2024-12-09T09:59:08Z

.github/workflows/merge-to-main.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

github-actions · 2024-12-09T09:59:09Z

.github/workflows/merge-to-stage.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

github-actions · 2024-12-09T09:59:10Z

.github/workflows/rcp-notifier.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

will use www.adobe.com cached calls of WCS

updating the job to manual trigger Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local>

* MWPW-154147-spectrum switch * MWPW-154147-spectrum switch * MWPW-154147-spectrum switch test * MWPW-154147-spectrum switch test --------- Co-authored-by: Sonja Popovic <cod55010@adobe.com>

github-actions · 2024-12-09T16:15:21Z

libs/features/spectrum-web-components/dist/checkbox.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-09T16:15:22Z

libs/features/spectrum-web-components/dist/switch.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-09T16:15:23Z

libs/features/spectrum-web-components/src/checkbox.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-09T16:15:25Z

libs/features/spectrum-web-components/src/switch.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

update tooltip locator Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@SantoshumarsMBP.attlocal.net>

markpadbe and others added 3 commits December 9, 2024 09:18

Adding Standalone gnav's default allowed origins (#3329)

e9f0bf2

* Fix: Setting allowedOrigins for standalone gnav * Fix: Default handling

milo-pr-merge bot requested a review from ryanmparrish as a code owner December 9, 2024 09:19

[MWPW-163539] Update RCP workflow (#3296)

93b846c

aem-code-sync bot temporarily deployed to stage December 9, 2024 09:58 Inactive

github-actions bot reviewed Dec 9, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge December 9, 2024 12:09 — with GitHub Actions Inactive

MWPW-156157 use OST v1.19.1 (#3290)

7483f29

will use www.adobe.com cached calls of WCS

milo-pr-merge bot requested a review from a team as a code owner December 9, 2024 12:09

aem-code-sync bot temporarily deployed to stage December 9, 2024 12:09 Inactive

mokimo temporarily deployed to milo_pr_merge December 9, 2024 12:11 — with GitHub Actions Inactive

[MWPW-163723] [NALA] Update Nala CircleCI Job to Manual Trigger (#3317)

57d66cf

updating the job to manual trigger Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local>

mokimo temporarily deployed to milo_pr_merge December 9, 2024 12:22 — with GitHub Actions Inactive

aem-code-sync bot had a problem deploying to feds-standalone-vfeds-standalone-v0.0.1 December 9, 2024 15:57 Failure

aem-code-sync bot had a problem deploying to feds-standalone-v0.0.1 December 9, 2024 15:59 Failure

mokimo temporarily deployed to milo_pr_merge December 9, 2024 16:14 — with GitHub Actions Inactive

MWPW-154147: add spectrum switch component (#3264)

9884681

* MWPW-154147-spectrum switch * MWPW-154147-spectrum switch * MWPW-154147-spectrum switch test * MWPW-154147-spectrum switch test --------- Co-authored-by: Sonja Popovic <cod55010@adobe.com>

github-actions bot reviewed Dec 9, 2024

View reviewed changes

[NALA][Table-Tooltip] Update tooltip locator (#3335)

39eafc8

update tooltip locator Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@SantoshumarsMBP.attlocal.net>

aem-code-sync bot temporarily deployed to stage December 9, 2024 17:48 Inactive

mokimo temporarily deployed to milo_pr_merge December 9, 2024 20:12 — with GitHub Actions Inactive

Roycethan approved these changes Dec 9, 2024

View reviewed changes

Roycethan added the Homepage SOT 👌 label Dec 9, 2024

Roycethan temporarily deployed to milo_pr_merge December 9, 2024 23:28 — with GitHub Actions Inactive

Dli3 approved these changes Dec 10, 2024

View reviewed changes

Dli3 added the BAcom SOT 👌 label Dec 10, 2024

Dli3 temporarily deployed to milo_pr_merge December 10, 2024 00:29 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge December 10, 2024 00:56 — with GitHub Actions Inactive

JackySun9 approved these changes Dec 10, 2024

View reviewed changes

JackySun9 added the MIQ SOT👌 label Dec 10, 2024

JackySun9 temporarily deployed to milo_pr_merge December 10, 2024 02:31 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge December 10, 2024 04:13 — with GitHub Actions Inactive

sigadamvenkata added the CC SOT 👌 label Dec 10, 2024

sigadamvenkata temporarily deployed to milo_pr_merge December 10, 2024 06:17 — with GitHub Actions Inactive

sigadamvenkata approved these changes Dec 10, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge December 10, 2024 08:15 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge December 10, 2024 09:17 — with GitHub Actions Inactive

milo-pr-merge bot merged commit 41ef7a9 into main Dec 10, 2024
45 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge December 10, 2024 09:17 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #3331

[Release] Stage to Main #3331

milo-pr-merge bot commented Dec 9, 2024 •

edited by overmyheadandbody

Loading

milo-pr-merge bot commented Dec 9, 2024

aem-code-sync bot commented Dec 9, 2024 •

edited

Loading

aem-code-sync bot commented Dec 9, 2024 •

edited

Loading

codecov bot commented Dec 9, 2024 •

edited

Loading

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

github-actions bot Dec 9, 2024

[Release] Stage to Main #3331

[Release] Stage to Main #3331

Conversation

milo-pr-merge bot commented Dec 9, 2024 • edited by overmyheadandbody Loading

common base root URLs

milo-pr-merge bot commented Dec 9, 2024

aem-code-sync bot commented Dec 9, 2024 • edited Loading

aem-code-sync bot commented Dec 9, 2024 • edited Loading

codecov bot commented Dec 9, 2024 • edited Loading

Codecov Report

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment

milo-pr-merge bot commented Dec 9, 2024 •

edited by overmyheadandbody

Loading

aem-code-sync bot commented Dec 9, 2024 •

edited

Loading

aem-code-sync bot commented Dec 9, 2024 •

edited

Loading

codecov bot commented Dec 9, 2024 •

edited

Loading