Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-163539] Update RCP workflow #3296

Merged

Conversation

overmyheadandbody
Copy link
Contributor

This tries to address a few issues with the current RCP workflow logic:

  • don't block the merge to stage pipe for RCPs shorter than 24h. The merge to main pipe will continue to be blocked;
  • don't send Slack notifications for RCPs lasting less than a day to avoid confusion;
  • adapt the logic that decides when to send the Slack notifications to avoid sending the same alert multiple times;
  • take the offset into account for the isWithinRCP method;
  • declare the number of minimum required SOT approvals as a secret.

Resolves: MWPW-163539

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 3, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (afe9047) to head (1655779).
Report is 111 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3296   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         245      245           
  Lines       56746    56746           
=======================================
  Hits        54698    54698           
  Misses       2048     2048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@overmyheadandbody overmyheadandbody merged commit 93b846c into adobecom:stage Dec 9, 2024
20 checks passed
@overmyheadandbody overmyheadandbody deleted the upate-rcp-workflow branch January 7, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants