MWPW-150560 make search literals usable as fragments #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3320 +/- ##
==========================================
+ Coverage 96.41% 96.73% +0.31%
==========================================
Files 246 323 +77
Lines 57568 67394 +9826
==========================================
+ Hits 55505 65193 +9688
- Misses 2063 2201 +138 ☔ View full report in Codecov by Sentry. |
yesil
approved these changes
Dec 11, 2024
3ch023
reviewed
Dec 11, 2024
3ch023
approved these changes
Dec 11, 2024
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
|
Reminder to set the |
Axelcureno
approved these changes
Dec 12, 2024
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
Closing this PR due to inactivity. |
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
vgoodric
added a commit
that referenced
this pull request
Jan 8, 2025
* ServiceNow CMR integration (#3392) * added servicenow CMR template added servicenow CMR template for github actions * updated template to remove skms updated template to remove skms and swap it with ServiceNow * started adding servicenow api calls started adding servicenow api calls * added the servicenow cmr calls. added the servicenow cmr calls. * test branch added test branch added * removed skms.yml where we are using servicenow removed skms.yml where we are using servicenow * updated function calls and parameters updated function calls and parameters * test update test update * Updated calls to output to file and check output Updated calls to output to file and check output for successful curl calls. Fixes jq parsing command. * testing output testing output * fixed github env variable declarations fixed github env variable declarations for token, cmr_id, transaction_id, release_title * added output to console for response from curl added output to console for response from curl * fixed file existence and size check fixed file existence and size check * small update small update * fixed curl statements and timestamps fixed curl statements and timestamps * another small update another small update * testing testing * testing theory testing theory * testing arguments testing arguments * second attempt second attempt * updated branch to remove caching updated branch to remove caching from GitHub Actions, hopefully. * reverted changes of new branch reverted changes of new branch * another small fix another small fix * testing a thought testing a thought * moved release summary to last param moved release summary to last param where it stops other parameters from being read. * testing out semantics for env variables testing out semantics for env variables * updated shell commands to fix errors updated shell commands to fix errors * small github env fixes small github env fixes * updated curl statement updated curl statement * updated calls and timespans updated calls and timespans * added printouts for debugging added printouts for debugging * small fixes small fixes * updated calls per guidance from winter solstice updated calls per guidance from winter solstice team * added new python script and removed shell script added new python scripts and removed shell script * added sanitization method added sanitization method * updated servicenow integration to use python updated servicenow integration to use python * updated variables and added headers updated variables and added headers * fixed cmr_id parsing and cmr closing fixed cmr_id parsing and cmr closing * added small test change for PR added small test change for PR * updated execution path * fixing environment variable access fixing environment variable access * fixed branches in yaml fixed branches in yaml * updated approvers, removed executor updated approvers, removed executor so that the default "Change Management API Integration" user is used instead. * changed stage variables, urls to prod changed stage variables, urls to prod * Add unc activity feed support for standalone gnav (#3386) * Ading uncConfig for unav * Ading uncConfig for unav * Lint fix * MWPW-163479: MAS - Switch to Spectrum CSS from SWC (#3289) * MWPW-162385 add wcsApiKey attribute * MWPW-161355: Update MAS documentation (#3135) * MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * merge MWPW-159374 * MWPW-161355: Update MAS documentation * Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span * cleanup all attributes during card hydration * remove deps/mas/mas.js * update test * update doc * allow list libs/features/mas/mas/dist/mas.js * change order in ignore * trying with wildcard * allow list dist * update hlxignore rules * update hlxignore rules * MWPW-161176: restructure ccd gallery (#3169) restructure ccd gallery * fix mas path * fix undefined error in merch-icon * fix regression in ctas size * update doc * fix css with checkout-link * fix random rtl issue * revert removal of mas.js from deps * update ccd gallery --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * MWPW-161845: basic analytics on mas cards (#3206) * MWPW-161845: add analytics * fix review changes * add build files * MWPW-159191: MAS Freyja support (#3209) * initial freyja commit * increase codecov * trival * add qa support to ccd page * improve page performance * update ccd.html * MWPW-161804: Merch card style auditing (#3216) Refactor merch-card styles to improve structure and specificity * Added space after price recurrence label for display-per-unit prices (#3196) * Added space after price recurrence label for display-per-unit prices * more specific selector * built * fix cr * built * adding example * MWPW-162933: merge mas modules (#3248) * MWPW-162933: merge mas modules + consonant-templates module from tacocat.js into a single module * MWPW-160755 - add tests for CCD cards (#3256) * MWPW-160755 - add tests for CCD cards * refactor and prepare dark mode checks * add tests for slice cards * activate dark for suggested and eslint fixes * add check for cta variant * fix multi mnemonic check * fix lint * add analytics check * remove comment * MWPW-163041: analytics fix (#3257) * MWPW-163041: fix analytics & add docs * add tests for analytics * add analytics docu * fix test * Fix overriding of border style on merch cards (#3278) * Fix overriding of border style on merch cards * width change * built --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Bump timeout from 2 to 10 sec (#3282) * bump to 10 seconds * new change * MWPW-163479: Switch to Spectrum CSS from SWC CCD app already provides Spectrum CCS styles. * update doc style * update doc style * update doc style * update doc style * update doc style * update doc style * Update styles * update docs * Keep SWC logic as an option * MWPW-161645: lana logging for CCD (#3271) * MWPW-161645: lana logging for CCD with <mas-commerce-service data-lana-tags="consumer=ccd" ...> lana will be enabled. TODO: Update docs * Update tests * fix review comments * add host env attribute, fix lana override * fix docs * fix unit tests * start loggin missing osi's * fix message * fix message * Update libs/features/mas/src/lana.js Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * PR review changes * avoid duplicate logging, log wcs url, limit page length in log * fix formatString error * fix render * add tests * fix loggin * revert ccd comments * fix milo tags --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * fix gaps with Spectrum CSS support * update version * fix gaps reported by ccd teamm * address gaps * address gaps * address gaps * address gaps * address gaps * fix for MWPW-163718 addressed design gaps. * addressed design gaps. * bump the version * add build artifacts * Update colors based on CCD app * Update colors based on CCD app * build without source maps * update Nala tests * fix lint * reset box-sizing for merch-card elements * Force box-sizing on merch-card * update styles: box-sizing * fix ccd gallery * update version * limit ccd price style to their variants * limit ccd price style to suggest variant * preserve white spaces in prices section * fix spacing in price * Update version * Update doc * update cards * update gallery styles * make the gallery responsive * align slice card ctas * cards resize responsively * fix 1x of gap issue * fix description text alignement * fix gaps in minimal widths * fix the gallery layout * Fix strikethrough price color in promos * Update nala tests * MWPW-164177: clean up card style on fragment * Added a new section to ccd gallery * update mas version * fix missing default spectrum css button style --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * MWPW-150560 make search literals usable as fragments (#3320) * MWPW-150560 make search literals usable as fragments * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * review comment * Update libs/blocks/merch-card-collection/merch-card-collection.js Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * fix unit test --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * MWPW-162046 Tabs - Stacked Mobile (#3351) * MWPW-162046 Tabs - Stacked Mobile * figma review adjustments * remove unused variable * MWPW-164084 [Catalog] Page position not preserved after closing the modal (#3375) * MWPW-164084 [Catalog] Page position not preserved after closing the modal * Trigger Build * MWPW-164084 [Catalog] Page position not preserved after closing the modal * MWPW-164084 [Catalog] Page position not preserved after closing the modal --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * [MWPW-161858] Remove sticky section when footer is visible (#3402) remove sticky section when footer is visible * MWPW-159299 Add chart role and dynamic aria labels (#3404) * MWPW-159299 Add chart role * Update echarts library and dynamically set aria text * Update aria settings * MWPW-156410: add daa-lh/ll values for gnav promo (#3413) * MWPW-162760 [MEP] Issues with inline fragments (#3415) initial push * created number of activities for pages * updated tests * updated activities number positioning * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * css change --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Brandon Marshall <bmarshal@adobe.com> Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Jan 9, 2025
…unt (#3416) * account for no stageDomainsMap * add unit test * less redundant * Update libs/features/personalization/preview.js add nala folder to exclusions * MWPW-164805 [MMM] Add manifest count to page list (#3430) * ServiceNow CMR integration (#3392) * added servicenow CMR template added servicenow CMR template for github actions * updated template to remove skms updated template to remove skms and swap it with ServiceNow * started adding servicenow api calls started adding servicenow api calls * added the servicenow cmr calls. added the servicenow cmr calls. * test branch added test branch added * removed skms.yml where we are using servicenow removed skms.yml where we are using servicenow * updated function calls and parameters updated function calls and parameters * test update test update * Updated calls to output to file and check output Updated calls to output to file and check output for successful curl calls. Fixes jq parsing command. * testing output testing output * fixed github env variable declarations fixed github env variable declarations for token, cmr_id, transaction_id, release_title * added output to console for response from curl added output to console for response from curl * fixed file existence and size check fixed file existence and size check * small update small update * fixed curl statements and timestamps fixed curl statements and timestamps * another small update another small update * testing testing * testing theory testing theory * testing arguments testing arguments * second attempt second attempt * updated branch to remove caching updated branch to remove caching from GitHub Actions, hopefully. * reverted changes of new branch reverted changes of new branch * another small fix another small fix * testing a thought testing a thought * moved release summary to last param moved release summary to last param where it stops other parameters from being read. * testing out semantics for env variables testing out semantics for env variables * updated shell commands to fix errors updated shell commands to fix errors * small github env fixes small github env fixes * updated curl statement updated curl statement * updated calls and timespans updated calls and timespans * added printouts for debugging added printouts for debugging * small fixes small fixes * updated calls per guidance from winter solstice updated calls per guidance from winter solstice team * added new python script and removed shell script added new python scripts and removed shell script * added sanitization method added sanitization method * updated servicenow integration to use python updated servicenow integration to use python * updated variables and added headers updated variables and added headers * fixed cmr_id parsing and cmr closing fixed cmr_id parsing and cmr closing * added small test change for PR added small test change for PR * updated execution path * fixing environment variable access fixing environment variable access * fixed branches in yaml fixed branches in yaml * updated approvers, removed executor updated approvers, removed executor so that the default "Change Management API Integration" user is used instead. * changed stage variables, urls to prod changed stage variables, urls to prod * Add unc activity feed support for standalone gnav (#3386) * Ading uncConfig for unav * Ading uncConfig for unav * Lint fix * MWPW-163479: MAS - Switch to Spectrum CSS from SWC (#3289) * MWPW-162385 add wcsApiKey attribute * MWPW-161355: Update MAS documentation (#3135) * MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * merge MWPW-159374 * MWPW-161355: Update MAS documentation * Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span * cleanup all attributes during card hydration * remove deps/mas/mas.js * update test * update doc * allow list libs/features/mas/mas/dist/mas.js * change order in ignore * trying with wildcard * allow list dist * update hlxignore rules * update hlxignore rules * MWPW-161176: restructure ccd gallery (#3169) restructure ccd gallery * fix mas path * fix undefined error in merch-icon * fix regression in ctas size * update doc * fix css with checkout-link * fix random rtl issue * revert removal of mas.js from deps * update ccd gallery --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * MWPW-161845: basic analytics on mas cards (#3206) * MWPW-161845: add analytics * fix review changes * add build files * MWPW-159191: MAS Freyja support (#3209) * initial freyja commit * increase codecov * trival * add qa support to ccd page * improve page performance * update ccd.html * MWPW-161804: Merch card style auditing (#3216) Refactor merch-card styles to improve structure and specificity * Added space after price recurrence label for display-per-unit prices (#3196) * Added space after price recurrence label for display-per-unit prices * more specific selector * built * fix cr * built * adding example * MWPW-162933: merge mas modules (#3248) * MWPW-162933: merge mas modules + consonant-templates module from tacocat.js into a single module * MWPW-160755 - add tests for CCD cards (#3256) * MWPW-160755 - add tests for CCD cards * refactor and prepare dark mode checks * add tests for slice cards * activate dark for suggested and eslint fixes * add check for cta variant * fix multi mnemonic check * fix lint * add analytics check * remove comment * MWPW-163041: analytics fix (#3257) * MWPW-163041: fix analytics & add docs * add tests for analytics * add analytics docu * fix test * Fix overriding of border style on merch cards (#3278) * Fix overriding of border style on merch cards * width change * built --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Bump timeout from 2 to 10 sec (#3282) * bump to 10 seconds * new change * MWPW-163479: Switch to Spectrum CSS from SWC CCD app already provides Spectrum CCS styles. * update doc style * update doc style * update doc style * update doc style * update doc style * update doc style * Update styles * update docs * Keep SWC logic as an option * MWPW-161645: lana logging for CCD (#3271) * MWPW-161645: lana logging for CCD with <mas-commerce-service data-lana-tags="consumer=ccd" ...> lana will be enabled. TODO: Update docs * Update tests * fix review comments * add host env attribute, fix lana override * fix docs * fix unit tests * start loggin missing osi's * fix message * fix message * Update libs/features/mas/src/lana.js Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * PR review changes * avoid duplicate logging, log wcs url, limit page length in log * fix formatString error * fix render * add tests * fix loggin * revert ccd comments * fix milo tags --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * fix gaps with Spectrum CSS support * update version * fix gaps reported by ccd teamm * address gaps * address gaps * address gaps * address gaps * address gaps * fix for MWPW-163718 addressed design gaps. * addressed design gaps. * bump the version * add build artifacts * Update colors based on CCD app * Update colors based on CCD app * build without source maps * update Nala tests * fix lint * reset box-sizing for merch-card elements * Force box-sizing on merch-card * update styles: box-sizing * fix ccd gallery * update version * limit ccd price style to their variants * limit ccd price style to suggest variant * preserve white spaces in prices section * fix spacing in price * Update version * Update doc * update cards * update gallery styles * make the gallery responsive * align slice card ctas * cards resize responsively * fix 1x of gap issue * fix description text alignement * fix gaps in minimal widths * fix the gallery layout * Fix strikethrough price color in promos * Update nala tests * MWPW-164177: clean up card style on fragment * Added a new section to ccd gallery * update mas version * fix missing default spectrum css button style --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * MWPW-150560 make search literals usable as fragments (#3320) * MWPW-150560 make search literals usable as fragments * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * review comment * Update libs/blocks/merch-card-collection/merch-card-collection.js Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * fix unit test --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * MWPW-162046 Tabs - Stacked Mobile (#3351) * MWPW-162046 Tabs - Stacked Mobile * figma review adjustments * remove unused variable * MWPW-164084 [Catalog] Page position not preserved after closing the modal (#3375) * MWPW-164084 [Catalog] Page position not preserved after closing the modal * Trigger Build * MWPW-164084 [Catalog] Page position not preserved after closing the modal * MWPW-164084 [Catalog] Page position not preserved after closing the modal --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * [MWPW-161858] Remove sticky section when footer is visible (#3402) remove sticky section when footer is visible * MWPW-159299 Add chart role and dynamic aria labels (#3404) * MWPW-159299 Add chart role * Update echarts library and dynamically set aria text * Update aria settings * MWPW-156410: add daa-lh/ll values for gnav promo (#3413) * MWPW-162760 [MEP] Issues with inline fragments (#3415) initial push * created number of activities for pages * updated tests * updated activities number positioning * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/blocks/mmm/mmm.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * css change --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Brandon Marshall <bmarshal@adobe.com> Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Brandon Marshall <bmarshal@adobe.com> Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing Geri's page: /drafts/gewittig/catalog-search-fragment-test-container?milolibs=MWPW-150560--milo--npeltier
Test URLs: