Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-164327] BulkPublisher BETA does not detect non-US lang & locale #3379

Merged
merged 15 commits into from
Jan 9, 2025

Conversation

cmiqueo
Copy link
Contributor

@cmiqueo cmiqueo commented Dec 13, 2024

Description:
BulkPublisher BETA does not detect non-US lang & locale because of hardcoded file name. This PR modifies the file name matching logic.

Resolves: MWPW-164327

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (29d77a6) to head (816fc19).
Report is 16 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3379   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         255      255           
  Lines       59253    59254    +1     
=======================================
+ Hits        57163    57165    +2     
+ Misses       2090     2089    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanrai
Copy link
Contributor

sanrai commented Dec 13, 2024

Hi @cmiqueo,

Are you intending for all the changes in the diff to be committed? Looks like your pr branch is out of sync.

Copy link
Contributor

aem-code-sync bot commented Dec 13, 2024

@cmiqueo cmiqueo added CaaS CaaS related code trivial PR doesn't require E2E testing by a reviewer Ready for Stage labels Dec 13, 2024
@cmiqueo cmiqueo changed the title MWPW-163075|: Updates local caas-tags.js fall-back file MWPW-163075: Updates local caas-tags.js fall-back file Dec 15, 2024
@cmiqueo cmiqueo changed the title MWPW-163075: Updates local caas-tags.js fall-back file Updates BulkPublisher BETA & local caas-tags.js fall-back file Dec 16, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 2, 2025

Skipped merging 3379: Updates BulkPublisher BETA & local caas-tags.js fall-back file due to failing checks

@cmiqueo cmiqueo changed the title Updates BulkPublisher BETA & local caas-tags.js fall-back file [MWPW-164327] BulkPublisher BETA does not detect non-US lang & locale Jan 6, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 7, 2025

Skipped merging 3379: [MWPW-164327] BulkPublisher BETA does not detect non-US lang & locale due to insufficient approvals. Required: 2 approvals

@milo-pr-merge milo-pr-merge bot merged commit 5ed9985 into stage Jan 9, 2025
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-163075 branch January 9, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CaaS CaaS related code Ready for Stage trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants