-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-164327] BulkPublisher BETA does not detect non-US lang & locale #3379
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3379 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 255 255
Lines 59253 59254 +1
=======================================
+ Hits 57163 57165 +2
+ Misses 2090 2089 -1 ☔ View full report in Codecov by Sentry. |
Hi @cmiqueo, Are you intending for all the changes in the diff to be committed? Looks like your pr branch is out of sync. |
|
Skipped merging 3379: Updates BulkPublisher BETA & local caas-tags.js fall-back file due to failing checks |
Skipped merging 3379: [MWPW-164327] BulkPublisher BETA does not detect non-US lang & locale due to insufficient approvals. Required: 2 approvals |
Description:
BulkPublisher BETA does not detect non-US lang & locale because of hardcoded file name. This PR modifies the file name matching logic.
Resolves: MWPW-164327
Test URLs: