Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed more issues specific to iOS #3448

Merged
merged 86 commits into from
Jan 10, 2025
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
48ee924
MWPW-161082 [Base Implementation] Mobile Global Nav Redesign Rollout …
sharmrj Nov 5, 2024
c316a70
Make mobile styles the default
sharmrj Nov 6, 2024
f77688a
Mobile Gnav Redesign for Adobe Home (#3151)
sharmrj Nov 7, 2024
c86c33b
Mobile gnav breadcrumbs new design (#3155)
bandana147 Nov 7, 2024
2b80657
Fixing css for no breadcrumbs page
bandana147 Nov 7, 2024
c95e7a6
Adding main menu placeholder (#3157)
bandana147 Nov 7, 2024
d3847da
Keyboard navigation for mobile gnav redesign (#3158)
sharmrj Nov 8, 2024
e86c0ce
Localnav design and event listeners (#3164)
bandana147 Nov 11, 2024
9e1e406
Handling CLS issue for localnav - mobile gnav redesign (#3198)
bandana147 Nov 20, 2024
151ba1a
Adding image support for large menu and medium menus on gnav (#3235)
bandana147 Nov 21, 2024
7f97145
Fixing dropdown promise issue
bandana147 Nov 21, 2024
9ad027a
Handle CLS issue on localnav: mobile redesign (#3253)
bandana147 Nov 26, 2024
99475c7
Temp window url for testinf
bandana147 Nov 27, 2024
24e08f9
Temp window url for testing
bandana147 Nov 27, 2024
96d1903
Added Analytics Attributes to Tabs and Tabpanels (#3275)
sharmrj Nov 28, 2024
fa26fc9
[MWPW-159665] - Gnav redesign animations (#3234)
Deva309 Nov 28, 2024
43c3993
Adding active column logic in a large menu (#3276)
bandana147 Nov 29, 2024
f04e702
[MWPW-159667] - Add dark mode fixes (#3285)
Deva309 Dec 5, 2024
d04e14d
[MWPW-163735] - Added Local Nav keyboard navigation for mobile GNAV r…
Deva309 Dec 9, 2024
cb64be6
Gnav bugs (#3346)
bandana147 Dec 10, 2024
1a087ce
Localnav z index to 9
bandana147 Dec 10, 2024
2673f0d
Fix: georouting issue
bandana147 Dec 10, 2024
7154444
[MWPW-164088] - UT for mobile GNAV redesign (#3359)
Deva309 Dec 12, 2024
985e3f6
Making localnav auto dismiss on click outside (#3368)
bandana147 Dec 12, 2024
3b300a4
Fix for multi level localnav click
bandana147 Dec 13, 2024
72459cd
UT fixes
Deva309 Dec 13, 2024
779a4b9
Making localnav close on curtain click
bandana147 Dec 13, 2024
378606d
Fix: String check update for localnav
bandana147 Dec 16, 2024
0d197e7
Adding disable-scroll when localnav is opened
bandana147 Dec 16, 2024
aeed0a1
Adding scroll for tabs
bandana147 Dec 16, 2024
ed0e956
Update libs/blocks/global-navigation/utilities/utilities.js
bandana147 Dec 16, 2024
ba3bbc4
Added fix for UT and bug MWPW-163859
Deva309 Dec 17, 2024
f2d2bca
Making the feature flag value to on
bandana147 Dec 17, 2024
d6aa444
Lint Fix
Deva309 Dec 17, 2024
b292d28
Decorating localnav before adding events
bandana147 Dec 18, 2024
39057f4
MWPW-163912
Deva309 Dec 18, 2024
e514dd8
MWPW-163912 bug fix
Deva309 Dec 18, 2024
66a09de
MWPW-163912 bug fix
Deva309 Dec 18, 2024
01d0a4f
[mobile gnav] view plans and pricing CTA added is not seen visible in…
sharmrj Dec 18, 2024
0a662ee
Changing the flag for new nav to off by default for standalone gnav
bandana147 Dec 18, 2024
43232bd
Removing list style
bandana147 Dec 18, 2024
7ffab67
Fix for bugs MWPW-163914 and MWPW-163907
Deva309 Dec 19, 2024
cbc835c
MWPW-163912 bug fix
Deva309 Dec 20, 2024
8ded884
MWPW-164385 [Mobile Gnav]when the megamenu is opened and scrolled see…
sharmrj Jan 2, 2025
72d297e
MWPW-163515: add daa-ll attributes for new mobile gnav elements (#3380)
nishantka Jan 2, 2025
2fa035a
[MWPW-160542] - LNAV accessibility
Deva309 Jan 2, 2025
5051e2f
Rempoving bold from multi level dropdown
bandana147 Jan 2, 2025
849db42
Making color of feds headline for localnav to link color
bandana147 Jan 2, 2025
bf8cf7e
[MWPW-164088] - UT fixes
Deva309 Jan 2, 2025
3bf33f8
Lint fixes
Deva309 Jan 2, 2025
39c00e1
[MWPW-164443] - Bug fix
Deva309 Jan 3, 2025
3dc1471
[MWPW-160542] - Accessibility Fixes
Deva309 Jan 3, 2025
9bf9238
UT and Lint Fixes
Deva309 Jan 3, 2025
7f25a5c
[MWPW-160542] - Accessibility Fixes
Deva309 Jan 3, 2025
658e11a
[MWPW-160542] - Accessibility Fix for breadcrumb
Deva309 Jan 3, 2025
ef5fae6
[MWPW-164648] & [MWPW-164649] Bug fix
Deva309 Jan 3, 2025
9495b6e
Fix: Checking for viewport before decorating localnav
bandana147 Jan 6, 2025
276a68b
[MWPW-164649] - accesibility fix for custom links
Deva309 Jan 6, 2025
b6d6f07
Fix: Adding checks for valid localNav
bandana147 Jan 6, 2025
475790d
Fix: font fix for button
bandana147 Jan 6, 2025
1aa6c5b
Lint fix
bandana147 Jan 7, 2025
e4f45b7
Decorating localnav
bandana147 Jan 7, 2025
5407b6b
Hiding localnav on desktop view
bandana147 Jan 7, 2025
c64363f
MWPW-163916 [Mobile GNAV] | Flickering issue while scrolling when LNA…
sharmrj Jan 7, 2025
8e86f07
[MWPW-164624] - Bug fix
Deva309 Jan 8, 2025
b0d094b
MWPW-164817 [Mobile GNAV] | The close button is not visible when the …
sharmrj Jan 8, 2025
490a349
Adding support for no megamenu localnav (#3421)
bandana147 Jan 8, 2025
3b4ee98
Mobile gnav tests (#3433)
sharmrj Jan 8, 2025
9a9d426
Mobile Gnav Standalone Localnav curtain was missing some styles (#3435)
sharmrj Jan 8, 2025
a4a7e92
Css fix for Megamenu title
bandana147 Jan 8, 2025
9a28c9d
Css fix for standalone localnav
bandana147 Jan 8, 2025
6856361
Css fix for standalone localnav
bandana147 Jan 8, 2025
d87d8d1
Making gnav promo sticky (#3434)
bandana147 Jan 8, 2025
d03aeb7
Fixed popup with promo (#3436)
sharmrj Jan 8, 2025
e6d0474
Font size fix for tabs
bandana147 Jan 9, 2025
3953f1a
Fixed the popup position for when there is no promo (#3439)
sharmrj Jan 9, 2025
31df6c1
[MWPW-164444] and [MWPW-164624] bug fixes
Deva309 Jan 9, 2025
e4268f4
Adding shadow to localnav bottom
bandana147 Jan 9, 2025
d7a44a0
Popup position fix for iPhone (#3440)
sharmrj Jan 9, 2025
8b5e0ec
Fixed popup not showing properly on safari
sharmrj Jan 9, 2025
5d169d0
added padding-bottom: env(safe-area-inset-bottom) for our popup
sharmrj Jan 9, 2025
7d392d6
min height 100dvh
sharmrj Jan 9, 2025
ac89529
removed min height and moved back to the old height
sharmrj Jan 9, 2025
17eb855
ios html height must be 100dvh
sharmrj Jan 9, 2025
728d85f
+ should be has
sharmrj Jan 9, 2025
5037f83
Merge branch 'mobile-gnav' of https://github.com/adobecom/milo into m…
sharmrj Jan 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions libs/blocks/global-navigation/global-navigation.css
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ header.global-navigation {

/* Hamburger toggle */
.feds-toggle {
width: 60px;
margin: 0;
padding: 0;
border: none;
Expand All @@ -104,6 +103,7 @@ header.global-navigation {
cursor: pointer;
font-size: 20px;
font-weight: 300;
padding-left: 20px;
}

.feds-toggle:before {
Expand Down Expand Up @@ -139,6 +139,7 @@ header.global-navigation {

.feds-brand {
display: flex;
padding-left: 22px;
}

.feds-logo {
Expand Down Expand Up @@ -877,6 +878,7 @@ header.new-nav .feds-nav > .feds-navItem > a.feds-navLink {

header.new-nav .feds-nav > section.feds-navItem > .feds-popup {
position: fixed;
transform: translate3d(0,0,0); /* render correctly on iOS Safari */
top: calc(-1 * var(--feds-height-nav));
visibility: hidden;
width: 100%;
Expand Down Expand Up @@ -1227,7 +1229,6 @@ header.new-nav .feds-breadcrumbs li:first-child:not(:nth-last-child(-n+3)):after
.feds-localnav.feds-localnav--active .feds-localnav-curtain {
width: 100%;
height: 101lvh;
padding-bottom: env(safe-area-inset-bottom);
background: var(--feds-color-black-v2);
opacity: 0.7;
}
Expand Down Expand Up @@ -1311,5 +1312,11 @@ header.new-nav .feds-breadcrumbs li:first-child:not(:nth-last-child(-n+3)):after
.disable-ios-scroll {
overflow: hidden;
width: 100%;
height: 100dvh;
position: fixed;
}

html:has(body.disable-ios-scroll) { /* this class is only added on iOS */
height: 100dvh;
position: fixed;
}
Loading