Fixed more issues specific to iOS #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place
* fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode
* Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css
* Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix
* Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue
* Localnav design and event listeners * Lint fix * Adding Overview title support
* Handling CLS issue by preserving space for localnav * Adding localnav config * Adding overview text from placeholder * Adding meta data check for new mobile gnav feature flag * Lint fix * Adding localnav only when mobile gnav v2 is true
* Adding image support on gnav * Decorating localnav only if it has one section * Lint fix
* Check for localnav * Moving getGnanSource to utils * Awaiting gnav source * Adding lanalog when there is mismatch with content and name * Lint fixes * Changing height of localnav
* Added analytics attributes to tabs and tabpanels * Handle cases where we don't find daa attributes
* MWPW-161082 [Base Implementation] Mobile Global Nav Redesign Rollout (#3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place * Make mobile styles the default * Mobile Gnav Redesign for Adobe Home (#3151) * fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode * Mobile gnav breadcrumbs new design (#3155) * Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css * Fixing css for no breadcrumbs page * Adding main menu placeholder (#3157) * Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix * Keyboard navigation for mobile gnav redesign (#3158) * Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue * Localnav design and event listeners (#3164) * Localnav design and event listeners * Lint fix * Adding Overview title support * Added animations for mobile redesign * Polish animations * Polish animations * polish animations * Resolved comment --------- Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Raghav Sharma <raghavs@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
* Adding active column logic in a large menu * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* dark mode changes * lint-fix * small fix for animation * Fix spacing and dark mode things for localnav * Set page overlay for local nav * Added some pending fix for keyboard navigation * Added some pending fix for keyboard navigation * Added some pending fix for keyboard navigation
…edesign (#3321) * Added localnav keyboard navigation for mobile gnav redesign * Added fixes for Local nav along with keyboard navigation * lint fix
* Fixing mega menu CTA height * Localnav z index and removing default makeActiveTab call
* UT for mobile GNAV redesign * lint fix * lint fix * lint fix * lint fix * Added More UT's
* Making localnav auto dismiss on click outside * making active link in localnav bold
…hamburger menu is clicked, and the screen shifts when clicking on the Adobe Creative Cloud drop-down (#3432) Fixed an issue on ios Safari where position fixed was changing the dimensions of the body element
* Fixed unit tests for gnav promo * Prevent other tests from breaking * Added a test case for safari * Added an escape test for localnav
* Added styles necessary for the standalone localnav to function * missed a css variable
* Moving Promo out of Header * Moving Promo out of Header * Cls fix for promo * Handling desktop gnav sticky * Removing has promo if no promo * Css fix * Test case fix * Test case fix * Test case fix * Test case fix
add a condition for when the nav promo offset is subtracted from the top of the popup
* add a condition for when the nav promo offset is subtracted from the top of the popup * fixed popup height for iphone * moved the popup 1px up
…obile-gnav-ios-hardware-acceleration
sharmrj
requested review from
salonijain3,
bandana147,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mobile-gnav #3448 +/- ##
===============================================
- Coverage 96.47% 96.46% -0.02%
===============================================
Files 256 256
Lines 59986 59985 -1
===============================================
- Hits 57874 57866 -8
- Misses 2112 2119 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.