Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ember 4 builds): exclude unused ember-keyboard initializer #603

Closed
wants to merge 1 commit into from

Conversation

gilest
Copy link
Collaborator

@gilest gilest commented Nov 15, 2021

It was breaking ember 4 builds.

Is this an acceptable way to deal with that?

I need to read the ember cli docs to make sure this won't exclude this file for addon consumers who actually want it.

Ref: adopted-ember-addons/ember-keyboard/issues/491

@gilest gilest force-pushed the fix/exclude-ember-keyboard-initializer branch from 57599b3 to d6c0d4d Compare November 15, 2021 01:25
@gilest
Copy link
Collaborator Author

gilest commented Nov 20, 2021

Resolved in #604 via adopted-ember-addons/ember-keyboard/pull/498

@gilest gilest closed this Nov 20, 2021
@gilest gilest deleted the fix/exclude-ember-keyboard-initializer branch January 26, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant