Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for latest Ember v4 beta/canary scenarios #498

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix CI for latest Ember v4 beta/canary scenarios #498

merged 1 commit into from
Nov 17, 2021

Conversation

SergeAstapov
Copy link
Contributor

This makes CI happy/green via:

  • updated .github/workflows/ci.yml to use the latest addon blueprint
  • Disabled ember-keyboard-first-responder-inputs initializer to avoid using removed built-in components
  • Upgrades couple of devDependencies to make CI pass: ember-auto-import@2 and ember-test-selectors
  • Updates tests/dummy/config/targets.js otherwise build fails with error originating in ember-auto-import/webpack due to invalid maintained node versions entry in targets.js
  • Updates some ember try scenarios to make CI happy for both ember 3.8 and 4.0-beta/4.1-canary at the same time

@SergeAstapov SergeAstapov changed the title Fix CI pass for latest Ember v4 beta/canary scenarios Fix CI for latest Ember v4 beta/canary scenarios Nov 16, 2021
@lukemelia lukemelia merged commit 9336a0a into adopted-ember-addons:master Nov 17, 2021
@lukemelia
Copy link
Collaborator

Thanks @SergeAstapov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants