Merge pull request #638 from adopted-ember-addons/key-responder-fixes

Make keyResponder ember-modifier@4 compat
adopted-ember-addons · Jul 12, 2022 · 0e25cd9 · 0e25cd9
2 parents ffbade8 + 8202aba
commit 0e25cd9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/addon/src/decorators/key-responder.js b/addon/src/decorators/key-responder.js
@@ -1,4 +1,5 @@
 import { inject as service } from '@ember/service';
+import { registerDestructor } from '@ember/destroyable';
 
 function populateKeyboardHandlers(responder) {
   responder.keyboardHandlers = responder.keyboardHandlers || {};
@@ -65,11 +66,10 @@ export default function keyResponder(opts = {}) {
         super(...arguments);
         populateKeyboardHandlers(this);
         this.keyboard.register(this);
-      }
 
-      willDestroy() {
-        this.keyboard.unregister(this);
-        super.willDestroy(...arguments);
+        registerDestructor(this, () => {
+          this.keyboard.unregister(this);
+        });
       }
     };
   };