Make keyResponder ember-modifier@4 compat #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
key-responder-fixes
branch
from
14c641a
to
8202aba
Compare
SergeAstapov
approved these changes
Jul 7, 2022
|
Thank you @NullVoxPopuli! unfortunately CI is not happy which it's unrelated to the changes in the PR, I'll take a look and try fox CI before landing this to not have a broken state of things. |
|
@SergeAstapov Could this be merged and released without fixing CI? |
|
@kellyselden merged! This is now available on npm as @lukemelia would you be able to publish a new minor with this change? |
|
@kellyselden @SergeAstapov published as 8.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting deprecations thrown from willDestroy from keyResponder used on an ember-modifier class-based modifier.
I think this change fixes things for everyone, and no more deprecations!