Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort icon gets mounted when the columns are narrow #600

Closed
Gorzas opened this issue Nov 19, 2018 · 1 comment · Fixed by #601
Closed

Sort icon gets mounted when the columns are narrow #600

Gorzas opened this issue Nov 19, 2018 · 1 comment · Fixed by #601

Comments

@Gorzas
Copy link
Contributor

Gorzas commented Nov 19, 2018

I have found that, in tables with a lot of columns or with narrow ones, the sort icon in the header gets mounted by the label like this (you can see it in the last name column):

screenshot from 2018-11-19 11-14-23

What do you think about changing the order of these lines? It doesn't totally fix the problem but at least the result is prettier than the current solution. Other way is adding the option to allow ellipsis on the headers 😄.

@tniezurawski
Copy link

This solution breaks our layout. IMHO it is crafted very much into specific needs now.

We show sorting arrows next to the text by overwriting this style to float: none:

.ember-light-table .lt-column .lt-sort-icon {
    float: right;
}

After this change, you are forced to use this specific layout where arrows go to the far right. Removing float: right leads to arrows shown on the left side, before the label:

image


If we could at least target {{label}} via CSS :P Would be nice to have it wrapped by <span>. We could then apply float: left; to that span and have the effect we wanted back.

Another option is to wrap the whole thing (icon + text) and let us style it. Then we could use flex and change the order of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants