Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid breaking line with sort icon in narrow columns #601

Conversation

Gorzas
Copy link
Contributor

@Gorzas Gorzas commented Nov 19, 2018

Close #600

@alexander-alvarez
Copy link
Collaborator

Hi @Gorzas, thanks for investigating this and proposing a solution. I'm happy to ideate to find something that works.
With the current change does this change the visual at all? Would the sort indicator show up on the left of the text?

@Gorzas
Copy link
Contributor Author

Gorzas commented Nov 20, 2018

With my solution, the headers are shown like this (I think it's a little bit prettier than the current option):

screenshot from 2018-11-20 08-54-42

My idea is that, when the column is too narrow, the name of the column and the sorting icons can fit together. This way, the developer can hide the text that doesn't fit (but I don't know if the ellipsis is something that should be in the library):

screenshot from 2018-11-20 08-55-49

@alexander-alvarez
Copy link
Collaborator

Got it. What you show in the first image vs the one in #600 is a good improvement.

Give me some time to run through the other pages manually to make sure everything else is OK, and then I'll merge.

Thanks again!

@alexander-alvarez
Copy link
Collaborator

Sorry for the delay. LGTM!

@alexander-alvarez alexander-alvarez merged commit 4ae1d5c into adopted-ember-addons:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort icon gets mounted when the columns are narrow
3 participants