[email regex] require a TLD with a minimum length of 2 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some Rails gems that enforce min 2 as well. |
|
I think this is a breaking change that would require a new major version release. Maybe we can have an option such as Edit:
This could be in case of public TLD's but there could exist private / corporate TLD of 1 char. |
|
@aronysidoro can you close this pull request? |
|
Closing in favor of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make a pull request for email validation for a minimum TLD length of 2.
We have some backend validation that says the TLD length should be between 2 and 63. I did some research, and there aren't any registered length of 1 TLD's. An RFC says the max length should be 63. Not sure if the max length validation is excessive though, so didn't add it in this pull request.