Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] allowNonTld & minTldLength in format validator #39

Merged
merged 5 commits into from
Dec 22, 2016
Merged

[FEATURE] allowNonTld & minTldLength in format validator #39

merged 5 commits into from
Dec 22, 2016

Conversation

offirgolan
Copy link
Collaborator

cc @snewcomer @aronysidoro 😸

This was referenced Dec 16, 2016
Closed
Closed
@snewcomer
Copy link
Collaborator

This looks much better. Nice work!

@offirgolan
Copy link
Collaborator Author

@snewcomer thank you. I do have a bit concern around using RegExp.prototype.source. Im not really sure how reliable it is nor what its browser compatibility is. I need to do some more research before merging this in.

@offirgolan offirgolan merged commit 381f165 into master Dec 22, 2016
@offirgolan offirgolan deleted the email-regex-options branch December 22, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offirgolan @snewcomer