Update openjdk/README.md #4036
Merged
Update openjdk/README.md #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yukiyuli thanks for your PR. Please update your PR title and description to reflect the change in your PR. Please refer Commit message example for details. Thanks. |
|
@llxia I tried to make some changes for commit changes. Please advise if it works. |
|
Thanks @yukiyuli for the update. A couple of issues:
|
Fixes: 4034 Signed-off-by: Yuki Yu <yukiyuli6688@gmail.com>
Fixes: 4033 Signed-off-by: Yuki Yu <yukiyuli6688@gmail.com>
|
Hello @llxia , I think that I fixed all issues. |
llxia
reviewed
Oct 17, 2022
openjdk/README.md
Outdated
| @@ -14,14 +14,14 @@ See the License for the specific language governing permissions and | |||
| # OpenJDK regression tests | |||
| This group of tests are the set that comes from the openjdk project, often referred to as jtreg tests, as the jtreg framework is the underlying executable used to execute them. The entire set of openjdk regression tests is quite large. For our nightly builds, we run only a subset of these tests (typically, those suites of tests that we 'tag' as sanity in the [playlist.xml](https://github.com/adoptium/aqa-tests/blob/master/openjdk/playlist.xml) file). For release builds, we intend to run the suites tagged as sanity and extended in the playlist. | |||
|
|
|||
| For more details on how the underlying jtreg harness works, you can refer to the ["How to Use the JTreg harness" guide](https://adoptopenjdk.gitbooks.io/adoptopenjdk-getting-started-kit/en/intermediate-steps/how_to_use_jtreg_-_java_regression_test_harness.html). | |||
| For more details on how the underlying jtreg harness works, you can refer to the ["How to Use the JTreg harness" guide](https://openjdk.org/jtreg/command-help.html). | |||
There was a problem hiding this comment.
We should add jtreg doc link, not replace the original "How to Use the JTreg harness" guide link.
There was a problem hiding this comment.
@llxia Thank you for your explanation. I update the change.
This reverts commit 186329d.
Fixes: 4033 Signed-off-by: Yuki Yu <yukiyuli6688@gmail.com>
This was referenced Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace adoptopenjdk.net with adoptium.net #4034
Add jtreg doc link in openjdk/README.md #4033