Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openjdk/README.md #4036

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Update openjdk/README.md #4036

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc53f0f
Replace adoptopenjdk.net with adoptium.net
yukiyuli Oct 14, 2022
186329d
Add jtreg doc link in openjdk/README.md
yukiyuli Oct 14, 2022
9d10fb3
Revert "Add jtreg doc link in openjdk/README.md"
yukiyuli Oct 17, 2022
b05e94c
Add jtreg doc link in openjdk/README.md
yukiyuli Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openjdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ See the License for the specific language governing permissions and
# OpenJDK regression tests
This group of tests are the set that comes from the openjdk project, often referred to as jtreg tests, as the jtreg framework is the underlying executable used to execute them. The entire set of openjdk regression tests is quite large. For our nightly builds, we run only a subset of these tests (typically, those suites of tests that we 'tag' as sanity in the [playlist.xml](https://github.com/adoptium/aqa-tests/blob/master/openjdk/playlist.xml) file). For release builds, we intend to run the suites tagged as sanity and extended in the playlist.

For more details on how the underlying jtreg harness works, you can refer to the ["How to Use the JTreg harness" guide](https://adoptopenjdk.gitbooks.io/adoptopenjdk-getting-started-kit/en/intermediate-steps/how_to_use_jtreg_-_java_regression_test_harness.html).
For more details on how the underlying jtreg harness works, you can refer to the ["How to Use the JTreg harness" guide](https://openjdk.org/jtreg/command-help.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add jtreg doc link, not replace the original "How to Use the JTreg harness" guide link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llxia Thank you for your explanation. I update the change.


## Running OpenJDK tests locally
While you can directly use the jtreg test harness to run these tests locally, we have also integrated them into our AQA test suite with TKG (TestKitGen) so that they can be run following the same pattern as any other AQA test:

0. Ensure your test machine is set up with [test prereqs](https://github.com/eclipse-openj9/openj9/blob/master/test/docs/Prerequisites.md). For openjdk tests, you do not need Docker installed.

1. Download/unpack the SDK you want to your test machine (you can download them from our website: [adoptopenjdk.net](https://adoptopenjdk.net/)).
1. Download/unpack the SDK you want to your test machine (you can download them from our website: [adoptium.net](adoptium.net).
1. `export TEST_JDK_HOME=</pathToWhereYouInstalledSDK>`
1. `git clone https://github.com/adoptium/aqa-tests.git`
1. `cd aqa-tests`
Expand Down